Closed Bug 1690500 Opened 9 months ago Closed 9 months ago

Do not pass user data down from the EntityDetails component twice

Categories

(Webtools Graveyard :: Pontoon, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mathjazz, Assigned: mathjazz)

Details

Attachments

(1 file)

We currently collect user data twice in the EntityDetails component and pass it as two different props (user and users) to:

  1. History > Translation > CommentsList > AddComment
  2. Helpers > TeamComments > CommentsList > AddComment

See:
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/entitydetails/components/EntityDetails.js#L57-L58
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/entitydetails/components/EntityDetails.js#L526-L527
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/entitydetails/components/EntityDetails.js#L448-L486

We should only pass the data once.

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.