Closed
Bug 1690500
Opened 4 years ago
Closed 4 years ago
Do not pass user data down from the EntityDetails component twice
Categories
(Webtools Graveyard :: Pontoon, enhancement, P3)
Webtools Graveyard
Pontoon
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mathjazz, Assigned: mathjazz)
Details
Attachments
(1 file)
We currently collect user data twice in the EntityDetails component and pass it as two different props (user and users) to:
- History > Translation > CommentsList > AddComment
- Helpers > TeamComments > CommentsList > AddComment
See:
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/entitydetails/components/EntityDetails.js#L57-L58
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/entitydetails/components/EntityDetails.js#L526-L527
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/entitydetails/components/EntityDetails.js#L448-L486
We should only pass the data once.
|
||
Comment 1•4 years ago
|
||
|
Assignee | |
Updated•4 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•