Closed Bug 1690504 Opened 5 years ago Closed 5 years ago

Improve newtab's handling of removed bookmarks

Categories

(Firefox :: New Tab Page, enhancement)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Iteration:
87.2 - Feb 8 - Feb 21
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: standard8, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file)

Bug 1690504: Batch handling bookmark-removed in newtabs.
48 bytes, text/x-phabricator-request
Details | Review

Bug 1607245 is adding patching of bookmark-removed notifications. I think it would be possible to improve new tab's code which internally notifies about updates to also handle batches:

https://searchfox.org/mozilla-central/rev/b2433a832c250c55255e0ee37d05192d04f20427/browser/components/newtab/lib/PlacesFeed.jsm#150-165

This would potentially allow the reduces to be updated once per batch, rather than once per bookmark removed.

Block removing is a rarer action, but this should help with our performance when we do hit it (e.g. bug 1562490).

Iteration: --- → 87.2 - Feb 8 - Feb 21
Points: --- → 2
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39406415a2d3 Batch handling bookmark-removed in newtabs. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/39406415a2d3

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: