1690510 - Perma opt js/src/wasm/WasmBuiltins.cpp:456:18: error: unused variable 'activation' [-Werror,-Wunused-variable] when Gecko 87 merges to Beta on 2021-02-22

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run such simulations
• Failure log

/builds/worker/checkouts/gecko/js/src/wasm/WasmBuiltins.cpp:456:18: error: unused variable 'activation' [-Werror,-Wunused-variable]

https://hg.mozilla.org/mozilla-central/rev/0d79003d2bab8f54911d8bf7780307ab0d466895#l9.96 defined the variable outside the assert and non-debug opt builds optimize the assert statement away.

Please provide a patch which also lets opt beta and release builds succeed.

Comment 1

[Lars T Hansen [:lth]]

Presumably just a missing DebugOnly<>

Comment 2

[Asumu Takikawa]

Whoops, sorry for the failure. Looks like the only non-debug use of the variable is #ifdefed with the exception handling build flag. I think I can just move the definition into the #ifdef and change the assert to use CallingActivation() directly as it did before. Will submit a patch to fix later today.

Comment 3

[Asumu Takikawa]

Attachment: Bug 1690510 - fix unused definition when wasm exceptions are off

This patch fixes release/beta builds where the compile flag
for Wasm exceptions are turned off.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8d905cabbdb
fix unused definition when wasm exceptions are off r=rhunt

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e8d905cabbdb

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation.