1690546 - Rust 1.51 nightly has warning-as-errors in webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[(Away)]

 1:18.78 error: field is never read: `handle`
 1:18.78    --> gfx\wr\webrender\src\gpu_cache.rs:651:5
 1:18.78     |
 1:18.78 651 |     handle: &'a mut GpuCacheHandle,
 1:18.78     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 1:18.78     |
 1:18.78     = note: `-D dead-code` implied by `-D warnings`
 1:18.78 error: field is never read: `map_child_pic_to_surface`
 1:18.78     --> gfx\wr\webrender\src\picture.rs:2260:5
 1:18.78      |
 1:18.78 2260 |     map_child_pic_to_surface: SpaceMapper<PicturePixel, PicturePixel>,
 1:18.78      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 1:18.78 error: variant is never constructed: `Resolve`
 1:18.78   --> gfx\wr\webrender\src\renderer\shade.rs:69:5
 1:18.78    |
 1:18.78 69 |     Resolve,
 1:18.78    |     ^^^^^^^

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: Fix Rust nightly warnings due to dead_code in WR

Note the handle comment - looks like a compiler bug to call it unused?

Comment 2

[Dzmitry Malyshau [:kvark]]

That handle warning looks like a Rust bug to me. We are reading this field in the destructor:

self.handle.location = Some(location);

Comment 3

[(Away)]

(In reply to Dzmitry Malyshau [:kvark] from comment #2)

That handle warning looks like a Rust bug to me. We are reading this field in the destructor:

self.handle.location = Some(location);

But that's a write, so it's still unread, no?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfe9e8cddc74
Fix Rust nightly warnings due to dead_code in WR r=gw

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bfe9e8cddc74