1690567 - Only show "Send Link/Tab/Page to device" items on tab / content context menus when you are signed in and have at least 1 other device available to send to

Status: VERIFIED FIXED

(Firefox :: Sync, enhancement, P2)

Description

[:Gijs (he/him)]

These items aren't useful if you're not signed in.

Ni Romain (see comment in presentation doc as well, slide 62 at time of writing) about whether we should hide the items if you're signed in but have no devices to send to.

Comment 1

[:Gijs (he/him)]

Romain answered this elsewhere and I am clarifying the summary accordingly.

Note that there is some subtlety here to deal with the fact that getting the list of devices is not sync, and happens (ideally) shortly after startup or is kickstarted once the user engages with sync UI. We should ensure that the changes here don't impact users who are signed in to sync and have devices, when they first open one of these context menus (noting that at least on macOS, I believe we cannot currently add menu items once the menu is open).

Comment 2

[Ryan Kelly [:rfkelly]]

These items aren't useful if you're not signed in.

A brief note for completeness: IIRC the reason they're currently shown even if you don't have devices to send to, is to help users discover that this feature exists and perhaps motivate them to add more devices.

(I have no objection to us deciding this is a bad or invalid reason and changing the behaviour - just leaving historical artifacts to note that the current behaviour was on purpose).

Comment 3

[:Gijs (he/him)]

It appears state here is again in flux, so closing for now until what we want here is more clear. I'll reopen once that is the case.

Comment 4

[:Gijs (he/him)]

(In reply to Ryan Kelly [:rfkelly] from comment #2)

These items aren't useful if you're not signed in.

A brief note for completeness: IIRC the reason they're currently shown even if you don't have devices to send to, is to help users discover that this feature exists and perhaps motivate them to add more devices.

(I have no objection to us deciding this is a bad or invalid reason and changing the behaviour - just leaving historical artifacts to note that the current behaviour was on purpose).

Right. For now, we'd like to simplify the content context and tab context menus like this.

Comment 5

[Sam Foster [:sfoster] (he/him)]

I'll have a go at this

Comment 6

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1690567 - Hide some sync context menu items when not signed in. r?markh!

Comment 7

[Sam Foster [:sfoster] (he/him)]

:mstange, blake suggested I ping you about this as I gather you are working on native context menus for MacOS. I'm not sure what that ends up meaning, but this patch is about ready for review otherwise. Will we still end up with the menu items being XUL elements with a .hidden property?

Comment 8

[Markus Stange [:mstange]]

Yes, the native menus will just be a reflection of what's in the XUL DOM, and they will respect the hidden property. Please go ahead.

Comment 9

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 10

[Romain Testard [:RT]]

Marking as P2. Per experience review we agreed to mark as P1 bugs only bugs that will block MR1.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dea371fb9249
Hide some sync context menu items when not signed in. r=markh

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dea371fb9249

Comment 13

[Bogdan Maris [:bogdan_maris], Desktop QA]

Verified that the "Send Link/Tab/Page to device" items are only available when one account is connected and has at least one device connected to it. Also checked that the functionality of it is not affected. Verified in latest Nightly 88.0a1 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3). Removing firefox87 since this was targeted for firefox88.