1690624 - Registering a rust thread with the profiler should be easy

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Florian Quèze [:florian]]

Or even better, not registering a rust thread with the profiler should be difficult.

Currently we have code doing things like:
https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/gfx/layers/wr/WebRenderBridgeParent.cpp#149-153

void gecko_profiler_register_thread(const char* name) {
  PROFILER_REGISTER_THREAD(name);
}

void gecko_profiler_unregister_thread() { PROFILER_UNREGISTER_THREAD(); }

https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/gfx/webrender_bindings/src/bindings.rs#1061

extern "C" {
    fn gecko_profiler_register_thread(name: *const ::std::os::raw::c_char);
    fn gecko_profiler_unregister_thread();
    fn wr_register_thread_local_arena();
}

Comment 1

[Florian Quèze [:florian]]

Here's another example of how it's currently being done: https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/dom/media/CubebUtils.cpp#498-500

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1690624 - Create an empty rust crate for profiler API r?gerald

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1690624 - Create empty ProfilerBindings header and cpp files r?gerald

Depends on D116513

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1690624 - Add profiler rust API for thread registration/unregistration r?gerald

Depends on D116514

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1690624 - Replace the old profiler thread registration FFIs with the new API in webrender r?jrmuizel

Depends on D116515

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1690624 - Replace the old profiler thread registration FFIs with the new API in servo r?emilio

Depends on D116516

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/102b7e2e1d23
Create an empty rust crate for profiler API r=emilio
https://hg.mozilla.org/integration/autoland/rev/17ab690c9058
Create empty ProfilerBindings header and cpp files r=gerald
https://hg.mozilla.org/integration/autoland/rev/bf15631f6360
Add profiler rust API for thread registration/unregistration r=gerald,emilio
https://hg.mozilla.org/integration/autoland/rev/398fcf75e15b
Replace the old profiler thread registration FFIs with the new API in webrender r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/66b6bf9d6c51
Replace the old profiler thread registration FFIs with the new API in servo r=emilio

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/102b7e2e1d23
https://hg.mozilla.org/mozilla-central/rev/17ab690c9058
https://hg.mozilla.org/mozilla-central/rev/bf15631f6360
https://hg.mozilla.org/mozilla-central/rev/398fcf75e15b
https://hg.mozilla.org/mozilla-central/rev/66b6bf9d6c51