1690783 - Number of scrollbar tick marks is incorrect

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Alice0775 White]

Build Autoland changeset 8d8a1ee8100cb65b9c54c95d3bb5aa659a0853e4

Steps to reproduce:

1. Open https://ftp.mozilla.org/pub/firefox/nightly/
2. Reduce browser height so that vertical scrollbar will appear
3. Open find bar (Ctrl+F)
4. Turn on [Highlight All]
5. Type 2021 (you should not use cut & paste)

Actual results:
There are two tick marks on the scrollbar

Expected Results:
There should be one.
Because, number of find matches is one n this case.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Early submission? Is this about bug 259640 comment 59?

Comment 2

[Alice0775 White]

Attachment: screenshot

Comment 3

[Neil Deakin]

I think this is caused by the later change to move the code into FinderHighlighter.jsm. For some reason, it doesn't really finish up when it says it does, (in FinderHighlight.update), so the value is the same as the old value.

I might just move the code back into Finder.jsm, or at least the call to updateScrollMarks.

Comment 4

[Gary [:streetwolf52]]

My observations:

1. Using the STR I only see one indicator line using Ctrl-F.

2. Using 'Search for text when you start typing' displays 2 indicator bars. However when I scroll the indicators disappear. Perhaps this method of searching is on a page by page basis.

Comment 5

[Neil Deakin]

Attachment: Bug 1690783, move call to updateScrollMarks to occur after the highlight and match count is determined to better ensure that the found ranges have been determined, r=mikedeboer

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b31293f0b8d
move call to updateScrollMarks to occur after the highlight and match count is determined to better ensure that the found ranges have been determined, r=mikedeboer

Comment 7

[Alexandru Michis [:malexandru]]

Backed out changeset 5b31293f0b8d (Bug 1690783) for causing bc failures in browser_findbar_marks.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2f4d46c963890136a88f6513d3b887a51033887d

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=windows%2C7%2Copt%2Cmochitests%2Ctest-windows7-32%2Fopt-mochitest-browser-chrome-e10s%2Cbc3&revision=93aab6a4a920da467ccd665401879bc51d750060&selectedTaskRun=LmAKF6Q5QDyewmcJkhnGgQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=329506435&repo=autoland&lineNumber=6291

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f734f1cbcd0
move call to updateScrollMarks to occur after the highlight and match count is determined to better ensure that the found ranges have been determined, r=mikedeboer

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4f734f1cbcd0

Comment 10

[Daniel Bodea [:danibodea]]

I cannot reproduce this issue after the fix. The number of highlight ticks is correct when using the STR in comment 0 or in any other situation I have attempted to reproduce.
@Alice: Can you also confirm this fix? Thank you!

Comment 11

[Alice0775 White]

The issue is no longer reproduced on Nightly87.0a1(20210216215129).