1690789 - Stop creating a new BreakpointList actor everytime we add/remove a breakpoint

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Julian Descottes [:jdescottes]]

We are not caching the breakpoint list actor on the server side:

  getBreakpointListActor() {
    return new BreakpointListActor(this);
  },

https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/devtools/server/actors/watcher.js#462-464

And we are not caching the corresponding front on the client side:
https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/devtools/client/debugger/src/client/firefox/commands.js#252,274

  const breakpointsFront = await targetList.watcherFront.getBreakpointListActor();
  await breakpointsFront.setBreakpoint(location, serverOptions);

So everytime we set/remove a breakpoint, we create a new actor.

Comment 1

[Julian Descottes [:jdescottes]]

Spotted this while implementing a similar pattern for the a ConfigurationActor in Bug 1690698

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1690789 - [devtools] Memoize breakpoint-list & networkParent getters in WatcherActor

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1690789 - [devtools] Create a single networkParent actor per watcher actor

Depends on D104073

Similar issue as for the breakpoint list actor, the networkParent actor can be created from the netmonitor, webconsole, and responsive UI

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1239fdf8725
[devtools] Memoize breakpoint-list & networkParent getters in WatcherActor r=ochameau

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d1239fdf8725