Add diagnostic assert if we encounter a stale blob key in the content process
Categories
(Core :: Graphics: WebRender, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The blob image code is written as if the blob key can never become invalid, unlike the image keys used for shared surfaces. Let's add a diagnostic assert to make sure this is true as there is suspicious behaviour in bug 1645841.
|
Assignee | |
Comment 1•3 years ago
|
||
This patch adds a diagnostic assert to check if the namespace of the
blob image key matches the current namespace of the process's
WebRenderBridgeChild. Other long lived users of image keys (i.e. shared
surfaces produced by imagelib) have to check to ensure their cached
image keys haven't gone out of scope due to a namespace update (e.g. tab
moved to a new window, GPU process crash). The caching for blob images
however is very different and should be cleared in these cases. This
assert will confirm this.
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2de18f2d894 Add diagnostic assert to ensure we aren't using stale blob keys. r=jrmuizel
|
||
Comment 3•3 years ago
|
||
Backed out for possibly causing reftest crashes in table-cell-breaking-1a.html:
https://hg.mozilla.org/integration/autoland/rev/78e94c5ff0474db6407bc5baa37504d12975d99d
Failure log: https://treeherder.mozilla.org/logviewer?job_id=328855800&repo=autoland
Backfills don't work because of a different issue affecting previous pushes.
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb6131fc97c9 Add diagnostic assert to ensure we aren't using stale blob keys. r=jrmuizel
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•