Closed Bug 1690863 Opened 2 years ago Closed 2 years ago

Remove gcOutput argument from ScopeStencil instantiation

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(2 files)

Refactor ScopeStencil::createScope to have a variant that does not use gcOutput as an argument. This allows constructing scopes at a finer granularity than the entire CompilationStencil.

Move the Scope -> Function/Module initialization to the same place as the
Function/Module -> BaseScript initialization. This simplifies initial scope
creation.

Instead, pass the enclosingScope argument explicitly. This makes it easier in
future to create a single scope independantly from the entire stencil which
gives more flexibility.

Depends on D104089

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ca896ce33af
Move Scope::canonical{Function,Module} initialization out of Scope. r=arai
https://hg.mozilla.org/integration/autoland/rev/244745c81b8f
Remove gcOutput argument from ScopeStencil::createSpecificScope. r=arai
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.