1690901 - Split nsTableWrapperFrame::OuterBeginReflowChild with other clean-up

Status: RESOLVED FIXED

(Core :: Layout: Tables, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

After bug 1690715, nsTableWrapperFrame::OuterBeginReflowChild becomes a method creating ReflowInput for both caption and inner table. We can split it into two separate methods rather than branching logic to handle both.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1690901 Part 1 - Make GetCaptionSide() and HasSideCaption() const methods.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1690901 Part 2 - Split and rename nsTableWrapperFrame::OuterBeginReflowChild() into two methods for caption and inner table.

Split OuterBeginReflowChild() so that we don't need to branch logic for
caption and inner table.

Rename the methods because OuterBeginReflowChild() only creates the ReflowInput,
and has nothing to do with actual reflow.

Depends on D104105

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1690901 Part 3 - Rename OuterDoReflowChild() to ReflowChild() for nsTableWrapperFrame.

Depends on D104106

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d1fbb7ea482
Part 1 - Make GetCaptionSide() and HasSideCaption() const methods. r=layout-reviewers,mats
https://hg.mozilla.org/integration/autoland/rev/33171dca5ccd
Part 2 - Split and rename nsTableWrapperFrame::OuterBeginReflowChild() into two methods for caption and inner table. r=layout-reviewers,mats
https://hg.mozilla.org/integration/autoland/rev/48895a7f84a6
Part 3 - Rename OuterDoReflowChild() to ReflowChild() for nsTableWrapperFrame. r=layout-reviewers,mats

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4d1fbb7ea482
https://hg.mozilla.org/mozilla-central/rev/33171dca5ccd
https://hg.mozilla.org/mozilla-central/rev/48895a7f84a6