Closed Bug 1690916 Opened 5 years ago Closed 4 years ago

Update Fission's subframe crash infobar to match UX's current infobar guidelines

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Fission Milestone M8
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- fixed

People

(Reporter: cpeterson, Assigned: enndeakin)

References

Details

Attachments

(2 files)

Neil, here are some requested UI changes from the UX team's latest infobar guidelines:

  • "Learn More" and "Submit Report" should use sentence case: "Learn more" and "Submit report".
  • "Learn more" should be a link, not a button.
  • The "Learn more" link and "Submit report" button should immediately follow the message text, not be right justified on the infobar.
  • The "X" close button should stay right justified.

See the attached screenshot of a reference infobar from UX deck https://docs.google.com/presentation/d/1Lt7w6FQIZDZAOO90UkeGwt6hcEZh3zElrVVCd7sSmD0/edit#slide=id.gbb1f1421fa_1_30

Flags: needinfo?(enndeakin)

Moving to Fission M8 because this UX changes don't need to block rolling out our Fission Beta experiment (M7). But it would be nice to have these changes for our Beta experiment because the new button design might increase the report submission rate.

Fission Milestone: M7 → M8

I suppose this also depends on some as-yet-not-filed bugs on the proton infobar changes that adds support for links.

Flags: needinfo?(enndeakin)
Attached image infobar_reference.png

(In reply to Neil Deakin from comment #2)

I suppose this also depends on some as-yet-not-filed bugs on the proton infobar changes that adds support for links.

Sounds like this bug will need to wait. No need to make the cosmetic changes like sentence casing the labels before then.

Also, this infobar's icon is likely to change from the red "sad tab" icon to a standard yellow warning icon (whose design is not yet finalized):

https://docs.google.com/presentation/d/1Lt7w6FQIZDZAOO90UkeGwt6hcEZh3zElrVVCd7sSmD0/edit#slide=id.gbb1f1421fa_1_9

Assignee: nobody → enndeakin
Status: NEW → ASSIGNED

The only thing to do here is change the case of the link and button to 'Learn more' and 'Submit report'.

Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a9c45cfbd3ac use sentence case for learn more link, r=fluent-reviewers,Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: