1690942 - Crash in [@ nsScriptSecurityManager::CheckLoadURIWithPrincipalFromJS]

Status: RESOLVED FIXED

(Core :: Security, defect, P1)

Description

[Sean Feng [:sefeng211]]

Crash report: https://crash-stats.mozilla.org/report/index/4295ab90-8fcd-408f-bf1b-2fe790210204

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL nsScriptSecurityManager::CheckLoadURIWithPrincipalFromJS caps/nsScriptSecurityManager.cpp:1141
1 XUL NS_InvokeByIndex 
2 XUL XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1142
3 XUL XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:925
4 XUL js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:594
5 XUL Interpret js/src/vm/Interpreter.cpp:3309
6 XUL js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:619
7 XUL JS::Call js/src/jsapi.cpp:2861
8 XUL mozilla::dom::MessageListener::ReceiveMessage dom/bindings/MessageManagerBinding.cpp:6309
9 XUL mozilla::dom::JSActor::CallReceiveMessage dom/ipc/jsactor/JSActor.cpp:271

A couple of null pointer crashes. aPrincipal was null?

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: Bug 1690942: Ensure CheckLoadURIWithPrincipalFromJS does not crash when receiving nullptr principal

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c9c0c0c5fd0
Ensure CheckLoadURIWithPrincipalFromJS does not crash when receiving nullptr principal r=dveditz

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1c9c0c0c5fd0