1690999 - [Wayland] glxtest broken on Weston

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert Mader [:rmader]]

Since bug 1640053 we do not fall back to GLX version in glxtest any more but only use EGL,PCI and Wayland APIs to determine graphics capabilities.

On my system, this fails on Weston and also does not properly fall back to GLX, result ing in a fallback to basic and no WebGL support. Gnome and Sway do work fine though, as does X11/GLX and X11/EGL.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1640053

Comment 2

[Robert Mader [:rmader]]

We don't ship Wayland by default yet, setting to disabled.

Comment 3

[Robert Mader [:rmader]]

So glxtest crashes in the Wayland code - with a quite odd stack:

#01: arena_dalloc(void*, unsigned long, arena_t*) (./gecko-dev/memory/build/mozjemalloc.cpp:3359)
#02: PageFree(mozilla::Maybe<unsigned long> const&, void*) (./gecko-dev/memory/replace/phc/PHC.cpp:0)
#03: replace_free(void*) (./gecko-dev/memory/replace/phc/PHC.cpp:0)
#04: destroy_xdg_output_manager_v1_info(void*) (./gecko-dev/toolkit/xre/glxtest.cpp:974)
#05: childgltest (./gecko-dev/toolkit/xre/glxtest.cpp:1206)
#06: fire_glxtest_process() (./gecko-dev/toolkit/xre/glxtest.cpp:1254)
#07: XREMain::XRE_mainInit(bool*) (./gecko-dev/toolkit/xre/nsAppRunner.cpp:3574)
#08: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) (./gecko-dev/toolkit/xre/nsAppRunner.cpp:5411)
#09: XRE_main(int, char**, mozilla::BootstrapConfig const&) (./gecko-dev/toolkit/xre/nsAppRunner.cpp:5501)

Comment 4

[Robert Mader [:rmader]]

Attachment: Bug 1690999: Initialize Wayland structs to zero, r=stransky

Certain fields are optional - if a compositor does not set it we
end up freeing uninitialized memory.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4825d87ae1cd
Initialize Wayland structs to zero, r=stransky

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4825d87ae1cd

Comment 7

[Robert Mader [:rmader]]

Comment on attachment 9201838 [details]
Bug 1690999: Initialize Wayland structs to zero, r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: A small number of Wayland users will have all acceleration disabled, including WR and WebGL. These users are likely developers.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only changing an uninitialized struct to 0-initialized, with no impact on logic otherwise. Only affects Wayland users.
• String changes made/needed:

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9201838 [details]
Bug 1690999: Initialize Wayland structs to zero, r=stransky

We are ending our beta cycle and the impact on end users seems low, I think it should ride the trains.