1691063 - newNewtabExperience: Top sites font size has become smaller on Linux

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Dão Gottwald [:dao]]

Attachment: screenshot with teeny-tiny top site labels

Bug 1690031 was filed to increase the font size, presumably on macOS. However, we were using a system font size before, and on Ubuntu this is above 12.

I believe you can use either font: caption;, font: menu;, or font: icon; to get bigger text on Mac without affecting other platforms.

prathiksha, could you please look into this?

Comment 1

[:prathiksha]

(In reply to Dão Gottwald [::dao] from comment #0)

Created attachment 9201449 [details]
screenshot with teeny-tiny top site labels

Bug 1690031 was filed to increase the font size, presumably on macOS. However, we were using a system font size before, and on Ubuntu this is above 12.

I believe you can use either font: caption;, font: menu;, or font: icon; to get bigger text on Mac without affecting other platforms.

prathiksha, could you please look into this?

Hi Dao, thanks for filing this bug. Engineering work has been paused on newNewtab at the moment. I will note this in our tracking sheet in case someone else wants to pick it up.

Comment 2

[:prathiksha]

(In reply to Dão Gottwald [::dao] from comment #0)

Bug 1690031 was filed to increase the font size, presumably on macOS. However, we were using a system font size before, and on Ubuntu this is above 12.

Also, this is probably a question for UX. The spec specifies a 12px font-size irrespective of the platform. CC'ing Julian Wels for clarification.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Fonts sizes below system sizes should be avoided for non-decorative text. Ideally, we use system font size as default (though there's no specific a11y requirement for the font size in WCAG).

Comment 4

[Julien Cristau [:jcristau] (back August 18)]

Did you get feedback from UX here?

Comment 5

[Julian Gaibler]

Hi!

I don't have Linux, so I don't know what it looked like before, but I'd argue that we should stick with 12px.

It would make sense to stick with the system font size if this was some sort of native UI, but since it's completely custom anyway, I think it's more important that new tab looks consistent across platforms :)

Comment 6

[:prathiksha]

(In reply to Julien Cristau [:jcristau] from comment #4)

Did you get feedback from UX here?

Work on newtab was paused and I'm no longer working on this project. Julian Wels might still be the UX point of contact for newtab changes.

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

Is newNewtabExperience something we're shipping, either by default or in experiments? Or is it disabled?

Comment 8

[Julian Gaibler]

It is planned to get enabled in release with 89, but there will be changes (e.g., match the proton style, fixing bugs) from now until then :)

Comment 9

[Dão Gottwald [:dao]]

Attachment: Bug 1691063 - Use native font size for top sites in new about:newtab. r=amy

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/913aa9fdc1cd
Use native font size for top sites in new about:newtab. r=amy,JulianWels

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/913aa9fdc1cd

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (90.0a1 Build ID - 20210525153449) installed on Linux Mint 20 x64. Now I can confirm that the text font size for the Top Sites is set to font: caption.