Closed Bug 1691120 Opened 4 years ago Closed 4 years ago

webrender::render_api::ApiMsg::WakeUp is unneeded

Categories

(Core :: Graphics: WebRender, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

Prior to bug 1662827, RenderBackend listened on one channel for ApiMsg messages from the RenderApi, and another channel for SceneBuilderResult messages from the SceneBuilderThread. Because synchronous Rust doesn't have any way to listen for messages on more than one channel simultaneously (in async Rust, you can select or race futures), RenderBackend would block on the ApiMsg channel, and SceneBuilderThread had to enqueue an ApiMsg::WakeUp on that channel to get RenderBackend to check the SceneBuilderResult channel.

Since bug 1662827, the SceneBuilderThread and the RenderApi share a single channel to the RenderBackend, so there's no need for the ApiMsg::WakeUp message, other than an assertion meant to help debug https://github.com/servo/servo/issues/13480, which has been closed since 2017.

Assignee: nobody → jimb
Status: NEW → ASSIGNED
Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eace403af243 Remove webrender::render_api::ApiMsg::WakeUp. r=nical
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: