1691287 - Remove needs_context=False from mako templates.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez (:emilio)]

I was chatting with the assignee to bug 1688695, and they found a compile error which was fixed by removing needs_context=False from inherited_table.mako.rs.

This is needed to be able to call Foo::parse(input), where Foo is a keyword, in which case it generates impl Foo { pub fn parse(input) ... }.

But we can always call the Parse trait / two-argument version of it, so as to avoid the footgun in the first place.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1691287 - Remove the need for needs_context in the mako glue. r=boris

It's only used to disambiguate between the one-argument and the trait
version of Keyword::parse. Instead, just explicitly use the trait
version, so that we don't need to specify it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/786ed9df69ff
Remove the need for needs_context in the mako glue. r=boris

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 786ed9df69ff (bug 1691287) for build bustages in gecko/layout/style/ServoCSSPropList. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=329288869&repo=autoland&lineNumber=1677

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=786ed9df69ff1c4a78146ebf6cf0fc1cf10ab192

Backout:
https://hg.mozilla.org/integration/autoland/rev/d91ba1c88ff527116c06efd06f9ed0792ffbe34d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a5bcecbdf3f
Remove the need for needs_context in the mako glue. r=boris

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9a5bcecbdf3f