1691353 - TestDictionaryBinding.cpp - GeckoProfiler.h:83:5: error: ?StackCaptureOptions? has not been declared

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

While building on Solaris I got following errors:

 2:07.30 In file included from ../TestDictionaryBinding.cpp:5:
 2:07.30 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/GeckoProfiler.h:83:5: error: ?StackCaptureOptions? has not been declared
 2:07.30    83 |     StackCaptureOptions aCaptureOptions) {
 2:07.30       |     ^~~~~~~~~~~~~~~~~~~
 2:08.73 In file included from ../TestExampleGenBinding.cpp:4:
 2:08.73 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/GeckoProfiler.h:83:5: error: ?StackCaptureOptions? has not been declared
 2:08.73    83 |     StackCaptureOptions aCaptureOptions) {
 2:08.73       |     ^~~~~~~~~~~~~~~~~~~
 2:09.62 In file included from ../TestCodeGenBinding.cpp:6:
 2:09.62 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/GeckoProfiler.h:83:5: error: ?StackCaptureOptions? has not been declared
 2:09.62    83 |     StackCaptureOptions aCaptureOptions) {
 2:09.62       |     ^~~~~~~~~~~~~~~~~~~
 2:10.25 gmake[4]: *** [/builds/psumbera/mozilla-central-build/config/rules.mk:676: TestDictionaryBinding.o] Error 1

where

The first bad revision is:
changeset:   566018:b17d03a52644
user:        Florian Quèze <[e-mail]>
date:        Thu Feb 04 07:13:21 2021 -0800
description:
	Bug 1690375 - Record markers with partial stacks for flushing pending notifications and marking a style flush as needed, r=gerald.

	Differential Revision: https://phabricator.services.mozilla.com/D103844

My mozcinfig file is:

ac_add_options --with-system-icu
ac_add_options --with-system-libevent
ac_add_options --with-system-zlib
ac_add_options --enable-js-shell
ac_add_options --prefix=/builds/psumbera/FIREFOX-INSTALL
ac_add_options --enable-jemalloc
ac_add_options --enable-replace-malloc
ac_add_options --enable-pulseaudio
ac_add_options --enable-debug
ac_add_options --disable-install-strip
# use gcc (not clang)
ac_add_options --enable-release
ac_add_options --enable-debug-symbols
ac_add_options --disable-install-strip
ac_add_options --disable-optimize
ac_add_options --disable-geckodriver
# https://bugzilla.mozilla.org/show_bug.cgi?id=1547217
ac_add_options --disable-verify-mar
# no nasm on intel yet
ac_add_options --disable-av1

Comment 1

[Petr Sumbera]

Florian, can you please have look at this one?

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Florian is on PTO this week, I'll take it.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690375

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1691353 - Fixed non-MOZ_GECKO_PROFILER build around StackCaptureOptions - r?canaltinova

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Petr, could you please try the attached patch? (I don't have Solaris!)

Comment 7

[Petr Sumbera]

Yes, the issue is now resolved. Thank you!

Any chance to build Firefox on Linux without profiler to avoid these kinds of issues?

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you for trying.

I'm not sure if we would be allowed to add a CI task to test unsupported platforms. 🤔
Anyway I'm hoping we'll get to bug 1635350 in the near future, which should remove these occasional breakages.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aa5443ff196
Fixed non-MOZ_GECKO_PROFILER build around StackCaptureOptions - r=canaltinova

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9aa5443ff196