1691359 - Don't call TRRIsOkay for cancelled TRR channels

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

When nsHostRecord::Cancel is called and the record has a pending TRR request, we end up calling Cancel for that request.
But right now we don't distinguish between a regular TRR timeout, and a request being cancelled, so we end up calling TRRIsOkay(OKAY_BAD) for such channels, potentially putting us into the NOT_CONFIRMED state.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1691359 - Don't call TRRIsOkay for cancelled TRR channels r=nhnt11

• Pass status code to cancelled TRR channels
• When TRR timer expires, use NS_ERROR_NET_TIMEOUT_EXTERNAL
• When TRR is cancelled by nsHostResolver use NS_ERROR_ABORT
• Only call TRRIsOkay in OnStopRequest (doing so in TRR::Cancel causes us to
  call it twice for the same TRR)
• Use NS_NewRunnableFunction instead of ProxyCancel runnable object
• Introduce TRR_REQ_CANCELLED skip reason

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87635dcb59f8
Don't call TRRIsOkay for cancelled TRR channels r=nhnt11

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/87635dcb59f8