1691433 - Remove "Check for Updates" menuitem from Help / macOS application menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1660848 added a new "Check for Updates" menuitem to both the Help menu, as well as the macOS Application Menu.

Product and Content Design have been converging on a number of simplifications to the Help menus / tertiary menus, and unfortunately this menuitem slipped in before their design had completed.

[Tracking Requested - why for this release]:

Bug 1660848 landed during the 86 Nightly cycle, so we'd like to see if we can get the menuitem removed and also uplifted in order to avoid unnecessary menu churn between 86 and 87.

Comment 1

[Bernard Igiri]

Attachment: Bug 1691433 - Remove check for updates option from application menus r=mconley,jaws

Removing Check For Updates button from menu.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2525abfe33bd
Remove check for updates option from application menus r=mconley,jaws,fluent-reviewers

Comment 3

[Bernard Igiri]

Comment on attachment 9202094 [details]
Bug 1691433 - Remove check for updates option from application menus r=mconley,jaws

Beta/Release Uplift Approval Request

• User impact if declined: The Check For Updates menu item will continue to appear.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Check the application menu in OSX for the absence of the Check For Updates menu item. Check the help menu in Windows and Linux for the absence of that menu item.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just backing out previous changes.
• String changes made/needed:

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2525abfe33bd

Comment 5

[Catalin Sasca, Desktop QA [:csasca]]

Verified that the "Check for update" option is no longer available on Firefox 87.0a1 (2021-02-11). Tests were performed on macOS 10.15.7, Ubuntu 20.04 and Windows 7.

Will verify it on beta as well as soon as it will be uplifted.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9202094 [details]
Bug 1691433 - Remove check for updates option from application menus r=mconley,jaws

Approved for our last beta, thanks.

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b613abb2e807

Comment 8

[Catalin Sasca, Desktop QA [:csasca]]

Verified on 86.0b9 and the "Check for update" option is no longer shown. Tests were performed on Ubuntu 20.04, macOS 11.2.1 and Windows 7