1691435 - [homedepot.com][Register]The "Password saved!" toast is not displayed upon editing the generated password

Status: NEW

(Core :: DOM: Forms, defect)

Description

[Andrei Purice]

Attachment: blue key.mp4

Affected Versions:

Nigthly 87.0a1 (2021-02-08)
Beta 86.0b7
Release 85.0.1

Tested On:
Windows 10x64

Steps to Reproduce:

1. Go to homedepot.com Register form: https://www.homedepot.com/auth/view/createaccount/diy
2. Click on the password field and select "generate password"
3. Focus out of the field and do any edits to the password

Expected:
The "Password saved!" toast is displayed upon editing the generated password .

Actual:
The "Password saved!" toast is not displayed upon editing the generated password .

Note:
This is not a regression as the issue can be traced back to Firefox 70.0 as well.

Comment 1

[Dimi Lee [:dimi]]

After discussing/testing with :edgar, it seems that this is a bug in DOM because the "change" event is not triggered for the password field.
That's why the "Password saved!" toast is not displayed.

Notes:
Chrome does trigger the change event when the password field is modified.

Comment 2

[Edgar Chen [:edgar]]

Attachment: test.html

The page sets input.value to "old" value (before receiving the input event) and then set back to "new" value (after receiving the input event) again in input event listener (not sure why the page does something like this).
This confuses https://searchfox.org/mozilla-central/rev/5120ec68572d946bd15101cf2ee2eaf4a210724f/dom/html/HTMLInputElement.cpp#2556, so it ends up not sending a change event.

Here is the minimal test show the same behavior.