1691435 - [homedepot.com][Register]The "Password saved!" toast is not displayed upon editing the generated password

Status: VERIFIED FIXED

(Core :: DOM: Forms, defect)

Description

[Andrei Purice]

Attachment: blue key.mp4

Affected Versions:

Nigthly 87.0a1 (2021-02-08)
Beta 86.0b7
Release 85.0.1

Tested On:
Windows 10x64

Steps to Reproduce:

1. Go to homedepot.com Register form: https://www.homedepot.com/auth/view/createaccount/diy
2. Click on the password field and select "generate password"
3. Focus out of the field and do any edits to the password

Expected:
The "Password saved!" toast is displayed upon editing the generated password .

Actual:
The "Password saved!" toast is not displayed upon editing the generated password .

Note:
This is not a regression as the issue can be traced back to Firefox 70.0 as well.

Comment 1

[Dimi Lee [:dimi]]

After discussing/testing with :edgar, it seems that this is a bug in DOM because the "change" event is not triggered for the password field.
That's why the "Password saved!" toast is not displayed.

Notes:
Chrome does trigger the change event when the password field is modified.

Comment 2

[Edgar Chen [:edgar]]

Attachment: test.html

The page sets input.value to "old" value (before receiving the input event) and then set back to "new" value (after receiving the input event) again in input event listener (not sure why the page does something like this).
This confuses https://searchfox.org/mozilla-central/rev/5120ec68572d946bd15101cf2ee2eaf4a210724f/dom/html/HTMLInputElement.cpp#2556, so it ends up not sending a change event.

Here is the minimal test show the same behavior.

Comment 3

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Edgar Chen [:edgar] from comment #2)

Created attachment 9203534 [details]
test.html

The page sets input.value to "old" value (before receiving the input event) and then set back to "new" value (after receiving the input event) again in input event listener (not sure why the page does something like this).
This confuses https://searchfox.org/mozilla-central/rev/5120ec68572d946bd15101cf2ee2eaf4a210724f/dom/html/HTMLInputElement.cpp#2556, so it ends up not sending a change event.

Here is the minimal test show the same behavior.

Nightly Fx 147 doesn't file the "change" event as well as Safari, but Chrome does file that.
What does the spec say here?

Comment 4

[Edgar Chen [:edgar]]

In https://html.spec.whatwg.org/#common-input-element-events, it says

any time the user commits the change, the user agent must queue an element task on the user interaction task source given the input element to set its user validity to true and fire an event named change at the input element, with the bubbles attribute initialized to true.

I think the spec expects a change event to be fired.

Comment 5

[Leo Tenenbaum [:ltenenbaum]]

Attachment: Bug 1691435 - Fire change event when value is set to pre-focus value and back. r=#dom-core

Comment 6

[Leo Tenenbaum [:ltenenbaum]]

Attachment: Bug 1691435 - Fire change event when value is set to pre-focus value and back. r=#dom-core

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/50cd3dc7b59c
https://hg.mozilla.org/integration/autoland/rev/d8928512b38a
Fire change event when value is set to pre-focus value and back. r=farre

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58369 for changes under testing/web-platform/tests

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d8928512b38a

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Ina Popescu, Desktop QA]

I was not able to reproduce the initial issue in older Nightly builds because the site shows the error "There was a temporary technical issue. Please try again later." when attempting to create an account. However I verified this in latest Nightly 151.0a1 and Firefox 150.0b4 on macOS 15, Windows 10, and Ubuntu 22.04, and the issue no longer persists. Marking this as Verified Fixed.