1691441 - [Cdiscount.com][Register][false-negative] Password Generation option is not displayed in the autocomplete dropdown

Status: VERIFIED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Andrei Purice]

Attachment: confirm.mp4

Affected Versions:

Nigthly 87.0a1 (2021-02-08)
Beta 86.0b7
Release 85.0.1

Tested On:
Windows 10x64

Steps to Reproduce:

1. Go to Cdiscount.com register page: https://order.cdiscount.com/Account/LoginLight.html?referrer=&o4=1
2. Click create an account.
3. Click on the Password field.

Expected:
Since we are on a register form, the password generation option should be offered in the autocomplete dropdown.

Actual:
The Password Generation option is offered on the Re-Type password field, but not for the new-password field.

Notes:

Reproducible on Chrome? Yes
Field attribute:
<input autocomplete="off" class="ipt_txt input-validation-error" id="CustomerLoginCreation_CustomerLoginCreationFormData_Password" name="CustomerLoginCreation.CustomerLoginCreationFormData.Password" type="password">
Regression-range: not a regression, this was not working from the point when we enabled password generation in FX70, site issue most probably since type="password" instead of "new-password"

Comment 1

[Tim Giles [:tgiles]]

It appears that Fathom is getting confused, but I'm not 100% sure why. The confirm password input is receiving a score of 96 from the Fathom model, but the password input is receiving a score of 29. We'll need to figure out why the model is throwing out such a low score.

Comment 2

[Dimi Lee [:dimi]]

The matching rules are:

formButtonIsLogin: coefficient(-2.284656524658203)
formHasLoginAction: coefficient(-0.4696630537509918)
formAttrsMatchLogin: coefficient(-1.166875958442688)
formButtonIsRegister: coefficient(2.889024496078491)
elementAttrsMatchLogin: coefficient(1.1432386636734009)
forgotPasswordOnPageLinkHref: coefficient(-0.3587746322154999)
forgotPasswordOnPageLinkTextContent: coefficient(-0.7233141660690308)

Comment 3

[Dimi Lee [:dimi]]

This is fixed by Bug 1692980.

Comment 4

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Firefox Nightly 90.0a1 (BuildID: 0210530214555) on MacOS 10.15. The password generation is now offered for the field and it also works as expected.
However, the generated password is not detected by the field validation, submitted Bug 1713590.