1691464 - Remove Take a Screenshot from the pageActions menu (change to a toolbar button)

Status: VERIFIED FIXED

(Firefox :: Screenshots, task, P1)

Description

[Mark Striemer [:mstriemer]]

With the removal of the meatball menu in the proton work, we'd like to move the Take a Screenshot button to the toolbar to allow users to hide it or put it in the overflow menu rather than being visible all the time.

Comment 1

[Mark Striemer [:mstriemer]]

I don't recall why I suggested this become a browserAction. The important part is that it isn't in the pageActions menu. Allowing a user to add a browserAction version to the toolbar/overflow menu seems nice, but it shouldn't show up there by default ever.

Comment 2

[Emma Malysz]

Attachment: Bug 1691464, remove screenshot feature from page action panel and move to dedicated widget

The widget is only added if screenshots are enabled (similar behavior to the fxa
toolbar button).
Button must take into account onLocationChange due to the fact that screenshots
extension is not available on about pages.
Adds a test for the disabled state, with more screenshot tests intended in the future

Comment 3

[Francesco Lodolo [:flod]]

Meridel, could you confirm if tooltips are supposed to use sentence case?

Comment 4

[Meridel [:meridel]]

Yes, tooltips should be sentence case. All desktop core UI should default to sentence case, with the exception of the Global OS menubar (which follows OS conventions), and context menus (which also follow OS conventions).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe59cb5b058b
remove screenshot feature from page action panel and move to dedicated widget r=fluent-reviewers,sfoster,flod

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a43d9f3ed4c
Fix prettier lint on browser_screenshot_button_disabled.js a=lint-fix CLOSED TREE

Comment 7

[Emma Malysz]

Attachment: Bug 1691464, remove screenshots webextension reference in test

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/342546c97873
remove screenshots webextension reference in test

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fe59cb5b058b
https://hg.mozilla.org/mozilla-central/rev/5a43d9f3ed4c
https://hg.mozilla.org/mozilla-central/rev/342546c97873

Comment 10

[Romain Testard [:RT]]

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Comment 11

[:Gijs (he/him)]

Emma, did we consider adding the button to the toolbar for users who had pinned the screenshots page action to the address bar?

Comment 12

[Emma Malysz]

We had discussed it before as a possibility, but I just confirmed with Romain that it's out of scope.

For reference, ~15k users have screenshots pinned to the URL bar and engaged with it within a 1 month period.

Comment 13

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe59cb5b058b
remove screenshot feature from page action panel and move to dedicated
widget r=fluent-reviewers,sfoster,flod

== Change summary for alert #29422 (as of Thu, 25 Mar 2021 05:32:04 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
29%	about_newtab_with_snippets	responsiveness	linux1804-64-shippable	e10s stylo	0.09 -> 0.07
20%	about_newtab_with_snippets	responsiveness	linux1804-64-shippable-qr	e10s stylo webrender	0.09 -> 0.08
19%	about_newtab_with_snippets	responsiveness	linux1804-64-shippable-qr	e10s stylo webrender	0.09 -> 0.08

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29422

Comment 14

[jpaulofarias]

Can I ask why was this removed from the 3 dots menu? I used to use it all the time and got confused when it was removed, I thought the feature was removed completely and was heartbroken. Then after some research I found out I can add it to the toolbar by customizing it but I gotta say I liked it more when it was in the 3 dots menu.

Someone on reddit also commented that page actions should be in that menu as per Mozilla's own guidelines so I am curious as to why it was removed from it.

Comment 15

[Sören Hentzschel]

I liked it more when it was in the 3 dots menu.

You can put it into the overflow menu of the toolbar. It's exactly the same, just a bit more on the right…

Comment 16

[jpaulofarias]

(In reply to Sören Hentzschel from comment #15)

I liked it more when it was in the 3 dots menu.

You can put it into the overflow menu of the toolbar. It's exactly the same, just a bit more on the right…

It is not really the same... I tried that and all it did was add an extra button to the toolbar (the overflow button) and the button to take a screenshot inside the menu that pops up when you click the overflow.

The 3 dots menu is always there, it is not an extra button that I need to add to my toolbar neither an extra menu.

Comment 17

[Sören Hentzschel]

I don't understand your comment. If you move the screenshot button to the overflow menu it is exactly the same. You need exactly the same amount of clicks and it's exactly the same functionality. The position of the button is the only difference.

Comment 18

[jpaulofarias]

Ok, let me try to explain better.

Right now I not NOT have an overflow button on my toolbar. Before this change I could click the 3 dots and then click take screenshot.

If I add it to the overflow button, a new button will show up and then I will have a single option inside that menu which is to take the screenshot. In this case I might as well just add the take screenshot button to the toolbar and save a click.

The difference is, I already have the 3 dots menu and I don't have a overflow menu.

Yes, the number of clicks would be the same but I would have an extra button.

Anyway, I am still confused as to why the option was removed from the 3 dots menu. Was there any discussion about the removal from the 3 dots menu and it was decided it was best to remove it?

Comment 19

[Sören Hentzschel]

Right now I not NOT have an overflow button on my toolbar. […] Yes, the number of clicks would be the same but I would have an extra button.

If you're talking about Firefox 88, then yes, it's an "extra button", but only for this one release. Starting with Firefox 89 the "three dots" menu no longer exists and it's no longer an "extra button", just a different position.

Anyway, I am still confused as to why the option was removed from the 3 dots menu. Was there any discussion about the removal from the 3 dots menu and it was decided it was best to remove it?

It was explained in the description of this bug: The "three dots" menu was removed from the address bar as part of the Proton redesign of Firefox 89. That's the reason why a toolbar button for this feature was created. This work already happened as part of Firefox 88.

Comment 20

[jpaulofarias]

Oh! The three dots menu will be gone on Firefox 89? I missed that part... So all the items currently under the three dots menu will become part of the overflow menu then?

Comment 21

[Sören Hentzschel]

There will not be a toolbar button for every feature of the "three dots" menu. But none of these features will be removed, they are all accessible either as toolbar button or via context menu.

Comment 22

[jpaulofarias]

Ok, gotcha! I guess I will have to get used to the new way.

Thanks for the patience of explaining this to me.

Comment 23

[Pablo]

verified meatball not visible anymore, and take screenshot is available on context menu and in customize toolbar on windows10 64bit, MacOS 10.15 and Ubuntu 20 64bit using Firefox nightly 90.0a1 and beta 89.0b10

Comment 24

[filipemaia]

Hi!

First of all, thank you for not removing the Screenshot feature. I do like it more as a toolbar button.

Second, I use the Screenshot feature a lot from the context menu (I just have to right click on a page an select the screenshot icon, it's so simple for me). If I upgrade to version 88, will I lose the possibility to use the screenshot function from the context menu?

Thanks.

Comment 25

[Sören Hentzschel]

If I upgrade to version 88, will I lose the possibility to use the screenshot function from the context menu?

No, it's still in the context menu.

Comment 26

[sd]

Just wanted to say thanks for removing the three dots menu - it's not like it will introduce additional cognitive load in users to get used to.

I am looking forward to removing also of the address bar, file menu, all the addons, and all buttons - and finally, we will have just an empty window with Google startpage, and we will not anymore have to get used and waste brain cycles on getting used to new UIs :) Firefox will be the best browser ever :) Is a utopia, but a man can dream ...