1691478 - Topsites order difference between remotesettings ON/OFF

Status: VERIFIED FIXED

(Firefox :: Top Sites, defect, P1)

Description

[Pablo]

When using the English_CA localized firefox with user.js region CA, i see a different order list in the amazon slot.

Tested on
Windows10 64bit

Affects:
Firefox Nightly 87.0a1
Firefox Release 85
Firefox Beta 86.0b7

Steps to reproduce

1. install firefox EN_CA localized version, and Use a user.js with :
   Region: CA
   Search log: true
   Remotesettings : ON
   Load Dump: FALSE

2. Run firefox with the above user.js, one with remotesettings ON, and another time with remotesettings OFF

3. Check topsite list order.

actual result
With remote settings ON, this is the order:
"1)Youtube
2)Amazon.ca
3)Facebook
4)Reddit
5)wikipedia
6)Twitter"

With remote settings OFF, this is the order:
"1)Youtube
2)Facebook
3)Reddit
4)wikipedia
5)Amazon.ca
6)Twitter"

Amazon has a different order

Expected result
Order should match with remotesettings on and off.

Comment 1

[Dão Gottwald [:dao]]

Did you get Amazon.ca as a search shortcut in both cases?

Comment 2

[Pablo]

Attachment: amazon.jpg

Comment 3

[Pablo]

Hi Dão
yes amazon.ca shortcut on both

Comment 4

[Dão Gottwald [:dao]]

There are two things happening here. First, this is a case where the old defaults would offer a shortcut without pinning it. The remote settings back-end doesn't support that, so this part is wontfix. Second, we may pin at the wrong position due to s.hostname not existing here: https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/components/newtab/lib/TopSitesFeed.jsm#431

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1691478 - Fix detecting existing search shortcuts. r=mikedeboer

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a71cb2eafb03
Fix detecting existing search shortcuts. r=mikedeboer

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a71cb2eafb03

Comment 8

[Petruta Horea [:phorea], PTO until 8/22/25]

Verified fixed on latest Nightly 87.0a1 2021-02-15 under Win 10 64-bit by opening it with RS off (amazon.ca was on 5th position) then changed to RS on and re-opened the browser (amazon.ca position wasn't changed).
Not marking as verified until we cover OSX and Ubuntu and we add a test for this kind of scenario.

Comment 9

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

Amazon.ca in legacy config is not pinned by default(no fecency) and position 5.
With the RS top-sites configuration at the date of this comment the position amazon.ca is on position 5 by default(no frecency) as well in both scenarios: migraton from legacy or new profile.

This was confirmed on a 87.0b9 try-build containing fix for bug 1696187.