1691499 - Convert Learn More buttons to text links

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

There are a number of notification bars that include a "Learn More" button that links to a SUMO page. Since this is really a link rather than an action, they should be shown as text links.

Slide 24 of the infobars deck lists the infobars that need to be updated.

It would be good to update the NotificationBox.appendNotification() method to accept a supportLink argument that can be used to consistently create this link [1].

Current some of these are added as buttons [2] and others have a text link manually appended to the message [3].

[1] https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/shared/components/NotificationBox.js#115
[2] https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/modules/ContentCrashHandlers.jsm#326
[3] https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/actors/PluginParent.jsm#760

Comment 1

[Neil Deakin]

Attachment: Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer

Comment 2

[Neil Deakin]

The design specifies that the links and buttons are on the left after the message text, whereas here they are still on the right. I wasn't clear what was going to happen when the message text wraps, but I just found an design image that shows that the link(s) should be part of the description, but the buttons should be on the next line. I'll see if I can change that in a second patch.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36b76c196497
add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser_decoderDoctor.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=36b76c196497ca9fa8ac4a95a651feffa5cad7ad&searchStr=bc&selectedTaskRun=NtaQ4XhYQHCJuVRG2bwxOQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331227148&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/a6f0e34af5894ce6995b2fab91ad8e6ca82da23e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adce7f3c1bbe
add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/adce7f3c1bbe

Comment 8

[Alex Thayer [:alexical] (she/her)]

Hey Neil - quick question: was it a deliberate decision to include the learn more button for content script hangs as well as add-on hangs? The link used to just be in add-on hangs and not in content script hangs.

Comment 9

[Neil Deakin]

I wasn't intending to change which notifications had learn more links.

Comment 10

[Simona Badau, Desktop QA, PTO 13-25aug]

Verified that "Learn how/Learn more" buttons were converted to text links for the following Info Bars:

• Media decode error: Microsoft Media Feature
• Media decode error: PulseAudio software
• Part of a page crash report
• Heartbeat
• Disk space low < 5GB
• Disk space low >5GB
  -Places locked
• Extension script slowing down the browser.

Verified on Mac OS X 11, on Ubuntu 20.04, and on Windows 10x64 using the latest Nightly 88.0a1.