1691517 - Nullptr dereference when processing tasks after main thread destruction

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Bas Schouten (:bas.schouten)]

For example, see: https://treeherder.mozilla.org/logviewer?job_id=326465839&repo=mozilla-central

It appears it's possible to hit https://searchfox.org/mozilla-central/source/xpcom/threads/TaskController.cpp#659-661 where NS_GetMainThread returns a nullptr. Right now we crash when this happens.

Comment 1

[Andrew McCreight [:mccr8]]

There's already bug 1690592 on file for this crash. You could dupe it over if you want.

Comment 2

[Andrew McCreight [:mccr8]]

Oops, I didn't mean to close this.

Comment 4

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1691517: Do not crash inside TaskController when the main thread is unavailable. r=smaug

Comment 5

[Bas Schouten (:bas.schouten)]

I did the very, most reliable thing of making sure a lack of main thread wouldn't crash task controller. Which is I think is a good thing. Andrew, do you want me to put up a patch trying to remove the event processing after ThreatManager shutdown altogether as well?

Comment 6

[Andrew McCreight [:mccr8]]

I'm not really familiar enough with event processing to have an opinion on how it should work late in shutdown, sorry.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feca4d091977
Do not crash inside TaskController when the main thread is unavailable. r=smaug

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/feca4d091977