1691526 - Enable 'os' level targeting for Nimbus Experiment

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add 'os' level targeting ( windowsVersion, windowsBuildNumber) to Nimbus experiments

https://searchfox.org/mozilla-central/source/toolkit/components/utils/ClientEnvironment.jsm#187

This will be needed for running Pinning and SetDefault experiments on targeted builds where feature is broken.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1691526 - Enable 'os' level targeting for Nimbus Experiment

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/195bf8b32fcb
Enable 'os' level targeting for Nimbus Experiment r=k88hudson

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_targeting.js

backout: https://hg.mozilla.org/integration/autoland/rev/782b03255c919c1b1ebe0d764cf3e6644dc56877

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=195bf8b32fcb2fb7daedab3de712d41efb10f2c4&selectedTaskRun=RrNQtWSMTbys_i3HcejG8Q.0&group_state=expanded&test_paths=toolkit%2Fcomponents%2Fmessaging-system%2Ftargeting%2Ftest%2Funit%2Fxpcshell.ini

failure log: https://treeherder.mozilla.org/logviewer?job_id=329403217&repo=autoland&lineNumber=3026

[task 2021-02-09T20:17:47.118Z] 20:17:47 INFO - TEST-START | toolkit/components/messaging-system/targeting/test/unit/test_targeting.js
[task 2021-02-09T20:17:47.898Z] 20:17:47 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/targeting/test/unit/test_targeting.js | xpcshell return code: 0
[task 2021-02-09T20:17:47.899Z] 20:17:47 INFO - TEST-INFO took 781ms
[task 2021-02-09T20:17:47.899Z] 20:17:47 INFO - >>>>>>>
[task 2021-02-09T20:17:47.900Z] 20:17:47 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-02-09T20:17:47.900Z] 20:17:47 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-02-09T20:17:47.901Z] 20:17:47 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-02-09T20:17:47.901Z] 20:17:47 INFO - running event loop
[task 2021-02-09T20:17:47.902Z] 20:17:47 INFO - toolkit/components/messaging-system/targeting/test/unit/test_targeting.js | Starting instance_with_default
[task 2021-02-09T20:17:47.904Z] 20:17:47 INFO - (xpcshell/head.js) | test instance_with_default pending (2)
[task 2021-02-09T20:17:47.904Z] 20:17:47 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-02-09T20:17:47.905Z] 20:17:47 INFO - TEST-PASS | toolkit/components/messaging-system/targeting/test/unit/test_targeting.js | instance_with_default - [instance_with_default : 18] Has local context - true == true

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59a56bf5a5d5
Enable 'os' level targeting for Nimbus Experiment r=k88hudson

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/59a56bf5a5d5