Closed
Bug 169155
Opened 22 years ago
Closed 21 years ago
move nsCompatibility.h to content/base/public
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: sicking, Assigned: sicking)
Details
Attachments
(1 file, 1 obsolete file)
1.31 KB,
patch
|
john
:
review+
|
Details | Diff | Splinter Review |
having nsCompatibility.h in layout makes nsIHTMLDocument depend on layout which
means that some modules (such as transformiix) get an unneccesary dependency.
The fix is to move it to mozilla/content/shared
David: you're the creator of that file, does that sound ok to you?
How about content/base/public/? I want content/shared to go away.
Assignee | ||
Comment 2•22 years ago
|
||
sure, as long as layout can reach it. r=you to move it? (i don't think any code
changes are needed and i'll ask leaf to cvs-move the file)
i'll make a testbuild here first of course to make sure everything works
Sure. layout depends on content already. :-)
Assignee | ||
Comment 4•22 years ago
|
||
doh! of course there's makefile changes needed
Comment 5•22 years ago
|
||
Comment on attachment 99602 [details] [diff] [review]
makefile changes
sr=jst. Have leaf copy the file to the new place in the repository.
Attachment #99602 -
Flags: superreview+
Comment on attachment 99602 [details] [diff] [review]
makefile changes
r=dbaron
Attachment #99602 -
Flags: review+
Assignee | ||
Updated•22 years ago
|
Blocks: txbranch
Summary: move nsCompatibility.h to content/shared → move nsCompatibility.h to content/base/public
Assignee | ||
Comment 7•22 years ago
|
||
So when i did a compleate build it turned out that now a list of modules needed
to add a dependency on content so that kind'a defeated the entire idea.
A better solution is to simply remove #include "nsCmpatibility.h" from
nsIHTMLDocument.h and just forward-declare the enum instead.
Attachment #99602 -
Attachment is obsolete: true
Comment 8•22 years ago
|
||
Comment on attachment 99707 [details] [diff] [review]
a better solution
r=jkeiser, lol :) This is indeed a good solution. r= is contingent on your
having done a full recompile of the tree ;)
Attachment #99707 -
Flags: review+
Comment on attachment 99707 [details] [diff] [review]
a better solution
gcc doesn't allow forward-declarations of an |enum|, and, as far as I can tell,
the C++ standard doesn't either.
Attachment #99707 -
Flags: needs-work+
Comment 10•22 years ago
|
||
file copied.
Comment 11•22 years ago
|
||
crap. i'll cvs remove from the bogus new location; missed that the comment
"better solution" meant "don't copy the file".
Updated•22 years ago
|
QA Contact: petersen → moied
Updated•22 years ago
|
Component: Layout → Layout: Misc Code
Assignee | ||
Comment 12•21 years ago
|
||
nevermind, layout and content are the same nowadays
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•