1691674 - [wpt-sync] Sync PR 27543 - Revert "webrtc: update addIceCandidate() call to match spec"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27543 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27543
Details from upstream follow.

b'Findit <[e-mail]>' wrote:

Revert "webrtc: update addIceCandidate() call to match spec"

This reverts commit ffc43d7a95f6b7843b3e476ab92bad05c8da669a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 852128 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZmYzQzZDdhOTVmNmI3ODQzYjNlNDc2YWI5MmJhZDA1YzhkYTY2OWEM

Sample Failed Build: https://ci.chromium.org/b/8855786209093867328

Sample Failed Step: compile

Original change's description:

webrtc: update addIceCandidate() call to match spec

see https://w3c.github.io/webrtc-pc/#interface-definition
This allows addIceCandidate() as end-of-candidates indication. This is
not yet implemented at the native layer.

BUG=chromium:978582

Change-Id: Id0f2acd2dcfdf4f5d311437df22c178c9d69630d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2680823
Commit-Queue: Philipp Hancke \<[e-mail]>
Reviewed-by: Guido Urdaneta \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#852128}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=chromium:978582

Change-Id: Ic1386562e0a5c1853f335f0db9c44b68a28ee946

Reviewed-on: https://chromium-review.googlesource.com/2683915
WPT-Export-Revision: 28f1dff6041dab59479c17d00bdf9759f4b27132

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0893fdaa6bb73ebf82c2c8d460b7650a55304b52

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 29 subtests

Status Summary

Firefox

OK : 1
PASS: 29

Chrome

OK : 1
PASS: 16
FAIL: 13

Safari

OK : 1
PASS: 9
FAIL: 20

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a9b7b3d0f93
[wpt PR 27543] - Revert "webrtc: update addIceCandidate() call to match spec", a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d63eba1f135
[wpt PR 27543] - Revert "webrtc: update addIceCandidate() call to match spec", a=testonly

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9d63eba1f135