Destroy target list at the end of Toolbox destroy
Categories
(DevTools :: Framework, task, P3)
Tracking
(firefox87 fixed)
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I would like to keep Bug 1691661 open to discuss the potential defects highlighted there. In the meantime, I think it should be safe to at least move the targetList.destroy next to the target.destroy in the toolbox destroy.
This way, all pending initializations and cleanup should be done.
We keep unwatchTargets/unwatchResources calls at their current spot in order to still stop client-side activity related to targets/resources as soon as possible.
|
Assignee | |
Comment 1•3 years ago
|
||
This is a partial fix for the issues highlighted in 1691661.
It should reduce the risk of race conditions during DevTools Toolbox destroy.
The race condition it fixes involves fronts which stop resolving requests after their corresponding remote frame target was destroyed.
See Bug 1691661 for more details.
|
||
Updated•3 years ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ac901ba324e [devtools] Destroy target list at the end of Toolbox destroy r=ochameau
|
||
Updated•3 years ago
|
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•