1691761 - Debug builds print "Attribute VertexAttribute { name: "aClipRect_TL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle"

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P4)

Description

[Markus Stange [:mstange]]

[task 2021-02-06T23:08:51.650Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 8, found at -1
[task 2021-02-06T23:08:51.650Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 10, found at -1
[task 2021-02-06T23:08:51.650Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 12, found at -1
[task 2021-02-06T23:08:51.657Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 14, found at -1
[task 2021-02-06T23:08:51.730Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 8, found at -1
[task 2021-02-06T23:08:51.730Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 10, found at -1
[task 2021-02-06T23:08:51.730Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_TR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 11, found at -1
[task 2021-02-06T23:08:51.730Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 12, found at -1
[task 2021-02-06T23:08:51.731Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_BL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 13, found at -1
[task 2021-02-06T23:08:51.731Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 14, found at -1
[task 2021-02-06T23:08:51.731Z] 23:08:51     INFO - GECKO(1689) | [2021-02-06T23:08:51Z WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_BR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 15, found at -1

Comment 1

[Lee Salzman [:lsalzman]]

This seems otherwise harmless, and I believe reflects the fact that we use the same vertex format for the cs_clip_rectangle shader regardless of what feature flags we supply. However, the shader compiler is probably determining under WR_FEATURE_FAST_PATH, we don't actually use those attributes and so chooses to optimize them out of that instance of the shader. I am not sure there is an easy way to get rid of this warning other than supplying difference formats.

Comment 3

[ISHIKAWA, Chiaki]

So these are simply ignorable, then.

However, he following is from the local mochitest log of comm-central TB.
The warnings are sorted according to the number of appearances
in the log. The frequencies are the first number on each line.

I see "shader composite" as opposed to cs_clip_rectangle.
Are they OK, too?

grep webrender log1402-mochitest-13.txt | grep -v gfx.webrender.all | cut -d " " -f 5- | sort | uniq -c | sort -n -k 1 -r

   5425  webrender::renderer] asking to enable_gpu_markers but no supporting extension was found
   1171  webrender::device::gl] Missing optimized shader source for gpu_cache_update
    948  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
    367 WARN  webrender::renderer] asking to enable_gpu_markers but no supporting extension was found
    162 WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
    107 WARN  webrender::device::gl] Missing optimized shader source for gpu_cache_update
    106  webrender::device::gl] Attribute VertexAttribute { name: "aUvRect2", count: 4, kind: F32 } is not found in the shader composite. Expected at 7, found at -1
    106  webrender::device::gl] Attribute VertexAttribute { name: "aUvRect1", count: 4, kind: F32 } is not found in the shader composite. Expected at 6, found at -1
    106  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 10, found at -1
    106  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 8, found at -1
    106  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 14, found at -1
    106  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 12, found at -1
     53  webrender::device::gl] Attribute VertexAttribute { name: "aColor", count: 4, kind: F32 } is not found in the shader composite. Expected at 3, found at -1
     53  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_TR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 11, found at -1
     53  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_BR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 15, found at -1
     53  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_BL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 13, found at -1
     14  webrender::device::gl] Attribute VertexAttribute { name: "aClipDeviceArea", count: 4, kind: F32 } is not found in the shader cs_clip_image. Expected at 1, found at -1
      8 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aUvRect2", count: 4, kind: F32 } is not found in the shader composite. Expected at 7, found at -1
      8 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aUvRect1", count: 4, kind: F32 } is not found in the shader composite. Expected at 6, found at -1
      8 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 10, found at -1
      8 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_TL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 8, found at -1
      8 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 14, found at -1
      8 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRect_BL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 12, found at -1
      4 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aColor", count: 4, kind: F32 } is not found in the shader composite. Expected at 3, found at -1
      4 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_TR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 11, found at -1
      4 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_BR", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 15, found at -1
      4 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipRadii_BL", count: 4, kind: F32 } is not found in the shader cs_clip_rectangle. Expected at 13, found at -1
      1 WARN  webrender::device::gl] Attribute VertexAttribute { name: "aClipDeviceArea", count: 4, kind: F32 } is not found in the shader cs_clip_image. Expected at 1, found at -1

There are shader composite warnings.

Comment 4

[Glenn Watson [:gw]]

These can be safely ignored - though, I think we should probably remove them from gecko altogether. I'm not sure the warnings serve any useful purpose for anyone.

Comment 5

[ISHIKAWA, Chiaki]

(In reply to Glenn Watson [:gw] from comment #4)

These can be safely ignored - though, I think we should probably remove them from gecko altogether. I'm not sure the warnings serve any useful purpose for anyone.

Thank you for the comment.
I am relieved because I was afraid that TB may be calling some graphical-related calls incorrectly (not that it is likely because graphical handling is buried deep inside GUI middleware.).

I am for the removal of the "warnings".
If these are printed as "INFO" or something with less ominous implication, I would be fine, though.

WARN vs INFO is pretty important for someone who does not know the code in detail.

Thank you again for clarification.

Comment 6

[Mathew Hodson]

The warning is at https://searchfox.org/mozilla-central/rev/44527269dd96db7a3da81aafff33c84a031864c7/gfx/wr/webrender/src/device/gl.rs#2385-2401

Would it be better to remove that whole section or change the warn! to info!?

Comment 7

[Glenn Watson [:gw]]

I think we could just remove that entire section.

Comment 8

[Mathew Hodson]

Attachment: Bug 1691761 - Remove noisy vertex attribute warning. r?gw

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b00ce0e94810
Remove noisy vertex attribute warning. r=gw

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b00ce0e94810