Closed
Bug 1691762
Opened 2 years ago
Closed 2 years ago
Switch save to Pocket button panel to fluent
Categories
(Firefox :: Pocket, enhancement, P2)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
91 Branch
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
From Bug 1688270
Right now the doorhanger requests the strings from the parent when it starts to load, but it was suggested we could use fluent to simplify that process, having the strings available in the panel without having to message the parent. The request the doorhanger currently does for strings adds some complexity, so if there is potential to make that better, I'm all for it.
Updated•2 years ago
|
Assignee: nobody → sdowne
Priority: -- → P2
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Noticed there is a number of templates we have that are no longer used.
Instead of migrating them to fluent, let's look at removing them first.
Doing that in bug 1701338.
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/6591aff2047f Save to Pocket button panels to fluent r=gvn,flod,fluent-reviewers
Comment 4•2 years ago
|
||
Backed out for causing mochitest failures in browser_pocket_AboutPocketParent
Backout link: https://hg.mozilla.org/integration/autoland/rev/bb9e79f6660cc04498c0b48fcd698bd6e5962bf9
Flags: needinfo?(sdowne)
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/ad5ee8fa1608 Save to Pocket button panels to fluent r=gvn,flod,fluent-reviewers
Comment 6•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(sdowne)
You need to log in
before you can comment on or make changes to this bug.
Description
•