Closed Bug 1691800 Opened 4 years ago Closed 4 years ago

Opening hamburger menu breaks Firefox if layout.frame_rate is set to 0 (ASAP mode)

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Version:
Firefox 87
Platform:
Unspecified
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox87 --- affected

People

(Reporter: cristian.silaghi, Unassigned)

References

Details

Attachments

(1 file)

troubleshooting_information.txt
69.84 KB, text/plain
Details

Browser is unresponsive anymore after opening the hamburger menu.

I can no longer click on any other tabs.

The only thing that keeps working normally is scrolling in the current page.

Please have a look: https://youtu.be/DiJBj1M57H0

Unfortunately, I cannot copy anything from the Browser Console.

I don't know what other information could be relevant for this.

Been hitting this issue for at least several weeks or months.

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → WebRTC
Product: Firefox → Core

Can you put the JSON version of the data in an attachment instead? It's very hard to read this split across 2 comments, it obscures other comments, and it confuses the bots... (edit: it looks like you pasted the same info about 6 times; I've tried to clean it up a bit.)

Does this happen any time you open the hamburger menu? Only some of the time?

Does this happen if you disable Fission and/or webrender? Does it happen on a clean profile? Does the browser console show any errors? (I don't know what you mean by "I can't copy anything" - does selecting text not work? Is the copy item greyed out? Does the ctrl+c shortcut not do anything -- but you could attach a screenshot failing all else.

If you open multiple browser windows, does it break in every window once you open one hamburger menu, or does it work in each window individually until you open the menu?

Does it break in private windows?

Component: WebRTC → Untriaged
Flags: needinfo?(cristian.silaghi)
Product: Core → Firefox
Flags: needinfo?(cristian.silaghi)

(In reply to :Gijs (he/him) from comment #3)

Can you put the JSON version of the data in an attachment instead? It's very hard to read this split across 2 comments, it obscures other comments, and it confuses the bots... (edit: it looks like you pasted the same info about 6 times; I've tried to clean it up a bit.)

Done. Sorry for that. See troubleshooting_information.txt

Does this happen any time you open the hamburger menu? Only some of the time?

It happens all the time.

Does this happen if you disable Fission?

Yes, I just tried.

Does it happen on a clean profile?

I'm not sure, but I'll try.

Does the browser console show any errors? (I don't know what you mean by "I can't copy anything" - does selecting text not work? Is the copy item greyed out? Does the ctrl+c shortcut not do anything -- but you could attach a screenshot failing all else.

There are some errors shown, see YouTube link in first comment, I opened Browser console at the end of video. I cannot select text, I cannot CTRL+A, I cannot copy contents of Browser Console. The only thing I can do with the mouse is scrolling up and/or down.

If you open multiple browser windows, does it break in every window once you open one hamburger menu, or does it work in each window individually until you open the menu?

Yup, it breaks in every Firefox window once I open any hamburger menu.

Does it break in private windows?

Yes. If I open the hamburger menu in private windows, it will break all other non-private windows as well.

Component: Untriaged → General

By the way, starting in safe mode seems to be much better. I mean, it doesn't break completely with all add-ons disabled.

It's just laggy or extremely laggy, see video: https://youtu.be/dAqy_yavhLY

Please note, it's exactly the same profile, but in safe mode.

(In reply to Cristian Silaghi from comment #6)

By the way, starting in safe mode seems to be much better. I mean, it doesn't break completely with all add-ons disabled.

It's just laggy or extremely laggy, see video: https://youtu.be/dAqy_yavhLY

Can you create a profile of the lagginess using https://profiler.firefox.com/ (probably want to start the profiler before opening the hamburger menu, then open and close it, then wait a few seconds where you see the lag, then finish the profile) , share it, and link it here?

Checking if this reproduces on a clean Firefox profile would also still be interesting.

Flags: needinfo?(cristian.silaghi)

Is this ok? https://share.firefox.dev/3a5XLXq

I'm not sure if I captured anything useful, it's pretty hard because many times Firefox got stucked or it was extremely unresponsive after running Profiler.

Flags: needinfo?(cristian.silaghi)

Christian, can you redo the profile with the "Graphics Firefox" preset?

Flags: needinfo?(cristian.silaghi)

Is your layout.frame_rate pref set to something other than -1? How about layers.offmainthreadcomposition.frame-rate?

Depends on: 1691850

(In reply to Markus Stange [:mstange] from comment #10)

Is your layout.frame_rate pref set to something other than -1? How about layers.offmainthreadcomposition.frame-rate?

layout.frame_rate is 0
layers.offmainthreadcomposition.frame-rate is -1

Flags: needinfo?(cristian.silaghi)

(In reply to Jeff Muizelaar [:jrmuizel] from comment #9)

Christian, can you redo the profile with the "Graphics Firefox" preset?

I'm trying for more than an hour, perhaps two, to get the profile with Firefox Graphics. Unfortunately, it doesn't work. Sometimes, it won't open a new tab to load profile, other times I cannot click in the page to upload and to share the performance profile. I guess I was lucky just for once. :(

Firefox ate ~10GB RAM few moments ago. Not sure if relevant to this bug, but pretty big RAM usage given the fact I have 10 tabs or something like this. :/

(In reply to Cristian Silaghi from comment #11)

layout.frame_rate is 0

Ok, that's the problem. Please set it to -1, which is the default.

Setting it to -1 fixes the problem. But why Firefox completely breaks with something other than -1?

Component: General → Layout
Product: Firefox → Core

Answer 1: Because this pref is only made for specific performance tests and is not exercised under other circumstances, so no effort has been spent on making it work for the general case.
Answer 2: Because refresh driver timer notifications are processed at a higher priority priority than other events, and a frame_rate of 0 indicates that we want to tick the refresh driver timer all the time. As a result, we never give other events a chance to be processed in the event loop.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Summary: Opening hamburger menu breaks completely Firefox → Opening hamburger menu breaks Firefox if layout.frame_rate is set to 0 (ASAP mode)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: