Closed Bug 1691821 Opened 3 years ago Closed 3 years ago

Refactor the Form Autofill system extension for reusable cross-platform components

Categories

(Toolkit :: Autocomplete, task, P1)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

()

Details

(Whiteboard: [geckoview:m88][geckoview:m89])

Attachments

(7 files)

Currently, desktop's form autofill implementation can not be shared across platforms.
In this bug, we'll track the work needed to refactor the system extension into reusable parts. The goal is to share as much code as possible across desktop and GeckoView.

See proposal for details.

Priority: -- → P1
Whiteboard: [geckoview:m88]
Whiteboard: [geckoview:m88] → [geckoview:m88][geckoview:m89]
Attachment #9208450 - Attachment description: Bug 1691821 - [1.0] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse. → WIP: Bug 1691821 - [1.1] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse.
Attachment #9208451 - Attachment description: Bug 1691821 - [2.0] Rename form autofill prefs and switch references to the toolkit module. → WIP: Bug 1691821 - [2.0] Rename form autofill prefs and switch references to the toolkit module.
Attachment #9208452 - Attachment description: Bug 1691821 - [3.0] Extend the form autofill component to support GeckoView. → WIP: Bug 1691821 - [3.1] Extend the form autofill component to support GeckoView.
Attachment #9208452 - Attachment description: WIP: Bug 1691821 - [3.1] Extend the form autofill component to support GeckoView. → WIP: Bug 1691821 - [3.2] Extend the form autofill component to support GeckoView.
Attachment #9208450 - Attachment description: WIP: Bug 1691821 - [1.1] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse. → Bug 1691821 - [1.a.1] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse.
Attachment #9208451 - Attachment description: WIP: Bug 1691821 - [2.0] Rename form autofill prefs and switch references to the toolkit module. → Bug 1691821 - [1.c.1] Rename autofill paths to use the new toolkit component.

Depends on D108058

Attachment #9208452 - Attachment description: WIP: Bug 1691821 - [3.2] Extend the form autofill component to support GeckoView. → Bug 1691821 - [2.3] Extend the form autofill component to support GeckoView.
Attachment #9208450 - Attachment description: Bug 1691821 - [1.a.1] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse. → Bug 1691821 - [1.a.2] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse.
Attachment #9212546 - Attachment description: Bug 1691821 - [1.b.1] Adjust build files to support the new autofill component. → Bug 1691821 - [1.b.2] Adjust build files to support the new autofill component.
Attachment #9208451 - Attachment description: Bug 1691821 - [1.c.1] Rename autofill paths to use the new toolkit component. → Bug 1691821 - [1.c.2] Rename autofill paths to use the new toolkit component.
Attachment #9208452 - Attachment description: Bug 1691821 - [2.3] Extend the form autofill component to support GeckoView. → Bug 1691821 - [2.4] Extend the form autofill component to support GeckoView.
Blocks: 1703977
Attachment #9212546 - Attachment description: Bug 1691821 - [1.b.2] Adjust build files to support the new autofill component. → Bug 1691821 - [1.b.3] Adjust build files to support the new autofill component.
Attachment #9212547 - Attachment description: Bug 1691821 - [1.d.1] Fix linter warnings for moved code. → Bug 1691821 - [1.d.2] Fix linter warnings for moved code.

Depends on D110272

Attachment #9208452 - Attachment description: Bug 1691821 - [2.4] Extend the form autofill component to support GeckoView. → Bug 1691821 - [2.5] Extend the form autofill component to support GeckoView.
Attachment #9208452 - Attachment description: Bug 1691821 - [2.5] Extend the form autofill component to support GeckoView. → Bug 1691821 - [2.6] Extend the form autofill component to support GeckoView.
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e955f7f5503c
[1.a.2] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse. r=zbraniecki,dimi,tgiles,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/1c86de8cd775
[1.b.3] Adjust build files to support the new autofill component. r=zbraniecki,dimi
https://hg.mozilla.org/integration/autoland/rev/cea92bd86972
[1.c.2] Rename autofill paths to use the new toolkit component. r=zbraniecki,dimi
https://hg.mozilla.org/integration/autoland/rev/abdc3fede62b
[1.d.2] Fix linter warnings for moved code. r=dimi
https://hg.mozilla.org/integration/autoland/rev/f807e0d0d095
[1.e.1] Disable perma-failing TV test. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/0affe1783697
[2.6] Extend the form autofill component to support GeckoView. r=erik,zbraniecki,dimi,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/d12aec06eedd
[3.1] Adjust form autofill extension tests to work with the shared component. r=zbraniecki,dimi
Attachment #9208450 - Attachment description: Bug 1691821 - [1.a.2] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse. → Bug 1691821 - [1.a.3] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse.
Attachment #9212546 - Attachment description: Bug 1691821 - [1.b.3] Adjust build files to support the new autofill component. → Bug 1691821 - [1.b.5] Adjust build files to support the new autofill component.
Attachment #9208451 - Attachment description: Bug 1691821 - [1.c.2] Rename autofill paths to use the new toolkit component. → Bug 1691821 - [1.c.3] Rename autofill paths to use the new toolkit component.
Attachment #9208452 - Attachment description: Bug 1691821 - [2.6] Extend the form autofill component to support GeckoView. → Bug 1691821 - [2.7] Extend the form autofill component to support GeckoView.
Attachment #9212548 - Attachment description: Bug 1691821 - [3.1] Adjust form autofill extension tests to work with the shared component. → Bug 1691821 - [3.2] Adjust form autofill extension tests to work with the shared component.
Flags: needinfo?(esawin)
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dec61fda8675
[1.a.3] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse. r=zbraniecki,dimi,tgiles,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/c91c629eb9c8
[1.b.5] Adjust build files to support the new autofill component. r=zbraniecki,dimi
https://hg.mozilla.org/integration/autoland/rev/80d9b39ab7cf
[1.c.3] Rename autofill paths to use the new toolkit component. r=zbraniecki,dimi
https://hg.mozilla.org/integration/autoland/rev/06d825d437e8
[1.d.2] Fix linter warnings for moved code. r=dimi
https://hg.mozilla.org/integration/autoland/rev/1e37447b9472
[1.e.1] Disable perma-failing TV test. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/5adea578d726
[2.7] Extend the form autofill component to support GeckoView. r=erik,zbraniecki,dimi,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/63817b788ed3
[3.2] Adjust form autofill extension tests to work with the shared component. r=zbraniecki,dimi,jmaher
See Also: → 1713137
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: