1691829 - Cocoa file picker does not specify interfaces for its file enumerators

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Kris Maglione [:kmag]]

Other platforms do, which means that JS callers which don't explicitly query each element are broken only on OS-X.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1691829: Specify interface for nsIFilePicker::files getter on Cocoa. r=mccr8

Without this, JS callers which don't explicitly query every element returned
by the enumerator are broken only on MacOS.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1db8a954cd69
Specify interface for nsIFilePicker::files getter on Cocoa. r=mccr8

Comment 3

[Andrew McCreight [:mccr8]]

It looks like the original motivation for this was a bug on Thunderbird based on ESR, so it might be nice to backport this fix if it is appropriate, in case there are other issues lurking there.

Comment 4

[Kris Maglione [:kmag]]

It might be nice, yeah, but I think their fix may be enough for those purposes. I think there's only one place in mozilla-central that would be affected by this, but there's an instanceof nsIFile check that makes it work even if the enumerator doesn't return the correct interface.

I was mainly worried about new code that lands and works correctly on automation and most platforms, but then blows up on OS-X when it actually ships.

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1db8a954cd69

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kmag, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.