Closed Bug 1691841 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27557 - Add WPTs and minor impl fixes for xr light estimation

Categories

(Core :: WebVR, task, P4)

Product:
Core
Component:
WebVR
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27557 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27557
Details from upstream follow.

b'Alexander Cooper <alcooper@chromium.org>' wrote:

Add WPTs and minor impl fixes for xr light estimation

Adds WPTs around expected behavior for the WebXR Light Estimation spec.
Also corrects a few cases where getReflectionCubeMap should have thrown
an exception but did not currently.

Change-Id: I3e3393c3911a83bdfc91463cf614e04a31dba009
Reviewed-on: https://chromium-review.googlesource.com/2685615
WPT-Export-Revision: cddaa0113ace2e697eb9b6230927df0cd71180fc

Component: web-platform-tests → WebVR
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 2 subtests

Status Summary

Firefox

OK : 7
FAIL: 14

Chrome

OK : 7
PASS: 12
FAIL: 2

Safari

OK : 7
FAIL: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/light-estimation/xrFrame_getLightEstimate_oldSession.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
getLightEstimate rejects if probe is from wrong session - webgl: FAIL (Chrome: PASS, Safari: FAIL)
getLightEstimate rejects if probe is from wrong session - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
/webxr/light-estimation/xrFrame_getLightEstimate_staleFrame.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
Cannot get XrLightEstimate from stale frame - webgl: FAIL (Chrome: PASS, Safari: FAIL)
Cannot get XrLightEstimate from stale frame - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
/webxr/light-estimation/xrFrame_getLightEstimate_valid.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
Can get XRLightEstimates during frame - webgl: FAIL (Chrome: PASS, Safari: FAIL)
Can get XRLightEstimates during frame - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
/webxr/light-estimation/xrSession_getLightProbe_ended.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
getLightProbe rejects on an ended session - webgl: FAIL (Chrome: PASS, Safari: FAIL)
getLightProbe rejects on an ended session - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
/webxr/light-estimation/xrSession_getLightProbe_notEnabled.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
getLightProbe rejects if not enabled on session - webgl: FAIL (Chrome: PASS, Safari: FAIL)
getLightProbe rejects if not enabled on session - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
/webxr/light-estimation/xrSession_getLightProbe_valid.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
Can create valid XRLightProbe objects - webgl: FAIL (Chrome: PASS, Safari: FAIL)
Can create valid XRLightProbe objects - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
/webxr/light-estimation/xrWebGLBinding_getReflectionCubeMap.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
Test that getReflectionCubeMap returns or throws appropriately without a reflection map. - webgl: FAIL (Chrome: FAIL, Safari: FAIL)
Test that getReflectionCubeMap returns or throws appropriately without a reflection map. - webgl2: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webxr/light-estimation/xrFrame_getLightEstimate_oldSession.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
/webxr/light-estimation/xrFrame_getLightEstimate_staleFrame.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
/webxr/light-estimation/xrFrame_getLightEstimate_valid.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
/webxr/light-estimation/xrSession_getLightProbe_ended.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
/webxr/light-estimation/xrSession_getLightProbe_notEnabled.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
/webxr/light-estimation/xrSession_getLightProbe_valid.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)
/webxr/light-estimation/xrWebGLBinding_getReflectionCubeMap.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72896cde23ab [wpt PR 27557] - Add WPTs and minor impl fixes for xr light estimation, a=testonly https://hg.mozilla.org/integration/autoland/rev/7db87e13a991 [wpt PR 27557] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84266482afea [wpt PR 27557] - Add WPTs and minor impl fixes for xr light estimation, a=testonly https://hg.mozilla.org/integration/autoland/rev/be91d5903599 [wpt PR 27557] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/84266482afea
https://hg.mozilla.org/mozilla-central/rev/be91d5903599

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.