1691854 - Hamburger menu icon shows update badge (green arrow) but Proton app menu doesn't have a "Restart to update" menu item

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Steps to reproduce

1. I set browser.proton.appmenu.enabled pref = true and restarted Nightly.
2. Later that day, I noticed the Nightly update badge (green arrow) overlaid on the hamburger menu icon.

Expected result

At this point, I usually open the hamburger menu and click the "Restart to update Nightly" menu item.

Actual result

But the Photon app menu no longer includes a "Restart to update Nightly" menu item.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Proton_app_menu_screenshot.jpg

Here's a screenshot of the current Proton app menu.

Comment 2

[Asif Youssuff]

I think this is a dupe of bug 1690662.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Asif Youssuff from comment #2)

I think this is a dupe of bug 1690662.

I don't think this bug is a dupe of bug 1690662. IIUC, that bug will add an app menu section "for things like update banners". But it doesn't necessarily mean that the "Restart to update Firefox" menu item has been implemented. After bug 1690662 is fixed, I can re-test this bug.

Comment 4

[:Gijs (he/him)]

The patch in bug 1690662 adds these.

Comment 5

[Chris Peterson [:cpeterson]]

Verified fixed by bug 1690662

Comment 6

[Raluca Popovici, Desktop QA]

I can reproduce this bug on Fx 87.0, with proton on, using Win 10.
According to the fix of the bug 1690662, I verified - Fixed in latest Nightly 90.0a1 (2021-04-19), Fx 89.0b2, Fx 88.0 and Fx 87.0b9,with proton on, using Windows 10x64 and Mac 11.