Closed Bug 1691886 Opened 3 months ago Closed 1 month ago

Consider removing BufferSize

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: jandem, Assigned: lth)

References

Details

Attachments

(1 file)

This wrapper around size_t was helpful to mark the places that still needed changes, but deprecatedGetUint32 will be removed soon and then it probably makes sense to replace BufferSize with size_t.

Note that BufferSize does not guarantee the wrapped size is <= the max ArrayBuffer byte length, so I don't think it's that useful to keep around going forward.

This can wait a few weeks until we have had more fuzzing.

Poaching.

Assignee: jdemooij → lhansen
See Also: → 1703505

Remove the BufferSize abstraction, replace it with size_t everywhere.

Depends on D111100

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.