1691887 - The google slides fullscreen is not correctly launched by keyboard

Status: NEW

(Core :: DOM: Core & HTML, defect)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Affected versions

• Fx86.0b7
• Fx87.0a1
• Fx85.0.2 RC

Affected platforms

• Windows 10
• Ubuntu 18.04
• macOS 10.13

Steps to reproduce

1. Launch Firefox.
2. Go to a Google Slide presentation e.g. https://docs.google.com/presentation/d/1RodWZwGQ7aM3AyxUTzX8IrBMkon2MkQSNe7jEQzBhhc/edit?usp=sharing
3. Make sure that a slide is selected by clicking it.
4. On the keyboard press CTRL+F5.
5. Press ESC (escape key) and then press CTRL+F5 again.

Expected result

• The fullscreen is launched again.

Actual result

• Fullscreen is not launched again.

Regression range

• This does not look like a recent regression.

Additional notes

• Any additional launches of fullscreen by keyboard is not correctly done.
• Clicking the 'Present' button correctly launches the fullscreen.
• Please note that bug 1502380 doesn't appear to be fixed by doing changes on our end on that particular issue, looking like this might be a google issue.
• This issue does not occur on Chrome (all keyboard fullscreen launches are correctly done).

Comment 1

[Alice0775 White]

Browser console shows an error:

Request for fullscreen was denied because Element.requestFullscreen() was not called from inside a short running user-generated event handler. 132887107-editor_js_prod_app__ja.js:6972:220
Uncaught (in promise) TypeError: Fullscreen request denied
    requestFullScreen https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:6972
    oMf https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:6997
    lMf https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:6995
    Zc https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:6989
    I3c https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:2120
    OQ https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:2118
    zhc https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:482
    fireAction https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:491
    MXc https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:1865
    LXc https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:1863
    dispatchEvent https://docs.google.com/static/presentation/client/js/365541258-editor_js_prod_core__ja.js:215
    J https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:1878
    JO https://docs.google.com/static/presentation/client/js/365541258-editor_js_prod_core__ja.js:140
    dispatchEvent https://docs.google.com/static/presentation/client/js/365541258-editor_js_prod_core__ja.js:138
    kYc https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:1878
    FPa https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:1876
    hfa https://docs.google.com/static/presentation/client/js/365541258-editor_js_prod_core__ja.js:137
    ffa https://docs.google.com/static/presentation/client/js/365541258-editor_js_prod_core__ja.js:137
    b https://docs.google.com/static/presentation/client/js/365541258-editor_js_prod_core__ja.js:268
    F https://docs.google.com/static/presentation/client/js/132887107-editor_js_prod_app__ja.js:4992
    a https://docs.google.com/static/presentation/client/js/365541258-editor_js_prod_core__ja.js:135
132887107-editor_js_prod_app__ja.js:6972:221

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b7dd0f12d98b0a00f61b7fab5c087932efd8f444&tochange=937f71d963aea2784fd7265fa0b05d8eb3ddb2b5

Suspect: Bug 1129227