1691976 - [Proton] "Exit" keyboard shortcut is not displayed in the AppMenu/Hamburger Menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Alin Ilea, Desktop QA]

Tested with:

Nightly 87.0a1 (2021-02-10)

Tested on:

Windows 7
Windows 10
Ubuntu 20.04

Preconditions:

In about:config, set browser.proton.appmenu.enabled = true

Steps:

1. Launch firefox and open the hamburger menu.
2. Observe the Exit option.

Actual result:

The keyboard shortcut for the "Exit" option (Ctrl+Shift+Q) from the hamburger menu is not displayed near the "Exit" string, like for the other ones (new tab, new window,downloads, etc.), but it works, the Ctrl+Shift+Q shortcut close the browser.

Expected result:

The "Exit" keyboard shortcut should be displayed next to the "Exit" string.

Notes:

• The "Exit" keyboard shortcut is displayed in the regular Nightly build (without Proton pref).
• The shortcut is displayed in the Proton UX/UI (Figma).

Comment 1

[Emma Malysz]

Attachment: Bug 1691976, add keyboard shortcut to quit button in proton app menu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a990b27ce92
add keyboard shortcut to quit button in proton app menu r=mconley

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2a990b27ce92

Comment 4

[Alin Ilea, Desktop QA]

Verified - Fixed in Beta 87.0b2 and latest Nightly build 88.0a1 (build id: 20210225041611) using Windows 10 and Ubuntu 18.04. Verified both with and without Proton enabled.