Closed Bug 1691976 Opened 2 months ago Closed 2 months ago

[Proton] "Exit" keyboard shortcut is not displayed in the AppMenu/Hamburger Menu

Categories

(Firefox :: Menus, defect, P3)

Firefox 87
defect

Tracking

()

VERIFIED FIXED
87 Branch
Tracking Status
firefox85 --- disabled
firefox86 --- disabled
firefox87 --- verified

People

(Reporter: alin.ilea, Assigned: emalysz)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-hamburger-menu])

Attachments

(1 file)

Tested with:

Nightly 87.0a1 (2021-02-10)

Tested on:

Windows 7
Windows 10
Ubuntu 20.04

Preconditions:

In about:config, set browser.proton.appmenu.enabled = true

Steps:

  1. Launch firefox and open the hamburger menu.
  2. Observe the Exit option.

Actual result:

The keyboard shortcut for the "Exit" option (Ctrl+Shift+Q) from the hamburger menu is not displayed near the "Exit" string, like for the other ones (new tab, new window,downloads, etc.), but it works, the Ctrl+Shift+Q shortcut close the browser.

Expected result:

The "Exit" keyboard shortcut should be displayed next to the "Exit" string.

Notes:

  • The "Exit" keyboard shortcut is displayed in the regular Nightly build (without Proton pref).
  • The shortcut is displayed in the Proton UX/UI (Figma).
Severity: S4 → N/A
Priority: -- → P3
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a990b27ce92
add keyboard shortcut to quit button in proton app menu r=mconley
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Flags: qe-verify+

Verified - Fixed in Beta 87.0b2 and latest Nightly build 88.0a1 (build id: 20210225041611) using Windows 10 and Ubuntu 18.04. Verified both with and without Proton enabled.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.