1691985 - Simplified cookie string in about:preference disappears after changing selection

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Simona Badau, Desktop QA]

Attachment: 2021-02-10_17h46_57.mp4

Affected Versions:
Firefox 86 beta 8

Tested On:
Windows 7

Preconditions:
set network.cookie.cookieBehavior to 5

Steps to Reproduce:

1. Launch Firefox
2. In the browser console add and press enter to:

Services.prefs.getDefaultBranch("").setIntPref("network.cookie.cookieBehavior", 5);
Services.prefs.setStringPref("browser.contentblocking.features.strict", "tp,tpPrivate,cookieBehavior5,cm,fp,stp,lvl2");
Services.prefs.setBoolPref("browser.contentblocking.state-partitioning.mvp.ui.enabled", true)

3. Navigate to about:preferences#privacy
4. Click on the "Custom" section and click on the cookies dropdown
5. From the cookies dropdown, select the third option

Expected:
5 cookie options should be available in the dropdown and all 5 should remain available after selection.

Actual:
The cookie string "Cross-site cookies - include social media cookies " disappears from the dropdown once the selection is changed. Please see the screencast for more details.

Notes:

• The issue is not reproducible on the latest Nightly 87.0a1.
• Not sure if this issue is dFPI related bug, please remove it if this is the case.

Comment 1

[Paul Zühlcke [:pbz]]

I can reproduce this bug, also in 86 release.
On a clean profile on release if you switch from "Standard" to "Custom", the option for cookieBehavior 5 ("Cross-site cookies - includes social media cookies") doesn't show up. It will only list cookieBehavior`1-4. If you switch to "Strict" and then to "Custom", 1-5 is listed. Updating the cookie behavior in custom will then cause the cookieBehavior 5 item to be removed again.

Steven, just to confirm: Since we now enable cookieBehavior 5 in strict mode we also want to list it as an option in the cookie dropdown in "Custom" at all times, correct?

Comment 2

[Paul Zühlcke [:pbz]]

Looks like we didn't flip this pref for release: https://searchfox.org/mozilla-central/rev/f1159268add2fd0959e9f91b474f5da74c90f305/browser/app/profile/firefox.js#1713

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1691985 - Enable cookieBehavior 5 dropdown option in custom category for beta and release channel. r=timhuang!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/886799ea9aa1
Enable cookieBehavior 5 dropdown option in custom category for beta and release channel. r=timhuang

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/886799ea9aa1

Comment 6

[Paul Zühlcke [:pbz]]

Comment on attachment 9205701 [details]
Bug 1691985 - Enable cookieBehavior 5 dropdown option in custom category for beta and release channel. r=timhuang!

Beta/Release Uplift Approval Request

• User impact if declined: In the tracking protection settings, when switching from "Standard" to "Custom" users can't select dFPI ("Cross-site cookies - include social media cookies").
  Workaround: Switch from Standard to Strict and then to Custom.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On Beta:

1. go to about:preferences#privacy
2. Switch from "Standard" to "Custom"
   The dropdown for "Cookies" in the "Custom" section should have 5 items, including "Cross-site cookies - includes social media cookies".

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're flipping a pref which has been enabled on Nightly for a while. Also, the pref only controls preferences UI.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9205701 [details]
Bug 1691985 - Enable cookieBehavior 5 dropdown option in custom category for beta and release channel. r=timhuang!

approved for 87.0b6

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d4b9305e020

Comment 9

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using Firefox 86.0 on Windows 10.
I verified the fix using Firefox 87.0b7 and Nightly 88.0a1 using Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.