1692018 - Remove support for installing OpenSearch engines via ftp

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

When we remove ftp support from Firefox, we should also remove support for loading OpenSearch engines from ftp.

This basically means changing the regexps in LinkHandlerChild.jsm and OpenSearchEngine.jsm.

Comment 1

[Valentin Gosu [:valentin] (he/him) [ooo until 25tth of May]]

Attachment: Bug 1692018 - Remove support for installing OpenSearch engines via ftp r=Standard8

Comment 2

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:valentin, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Mark Banner (:standard8)]

Assuming this is waiting for FTP's removal.

Comment 4

[Valentin Gosu [:valentin] (he/him) [ooo until 25tth of May]]

I just missed the r+ email. I'll land it ASAP.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/120d1b7f97d0
Remove support for installing OpenSearch engines via ftp r=Standard8

Comment 6

[Atila Butkovits]

Backed out for casuing failures on browser_search_discovery.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/bceca3940d0ef2a29287e50cbb66156dc1dddf55

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-e10s%2Cbc3&revision=120d1b7f97d0b16164cc3a2e77fd16324ef6ed80&selectedTaskRun=UscuxKUrSAiftfaRkyycgw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=334558146&repo=autoland&lineNumber=7664

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbe060c7c770
Remove support for installing OpenSearch engines via ftp r=Standard8

Comment 8

[Valentin Gosu [:valentin] (he/him) [ooo until 25tth of May]]

Attachment: Bug 1692018 - Fix LinkHandlerChild protocol regex r=evilpie

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62a94cbcdb7e
Fix LinkHandlerChild protocol regex r=evilpie

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fbe060c7c770
https://hg.mozilla.org/mozilla-central/rev/62a94cbcdb7e