1692058 - Running multiple junit classes locally is broken

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

:nika reported this on matrix, running multiple junit classes with mach geckoview-junit results in:

 ./mach geckoview-junit org.mozilla.geckoview.test.ExtensionActionTest org.mozilla.geckoview.test.WebExtensionTest

...

Traceback (most recent call last):
  File "/Users/asferro/workspace/mozilla-central/objdir/_tests/testing/mochitest/runjunit.py", line 620, in run_test_harness
    result = runner.run_tests(
  File "/Users/asferro/workspace/mozilla-central/objdir/_tests/testing/mochitest/runjunit.py", line 351, in run_tests
    cmd = self.build_command_line(
  File "/Users/asferro/workspace/mozilla-central/objdir/_tests/testing/mochitest/runjunit.py", line 192, in build_command_line
    print(f.encode(), file=filter_list)
  File "/usr/local/Cellar/python@3.9/3.9.1_8/Frameworks/Python.framework/Versions/3.9/lib/python3.9/tempfile.py", line 474, in func_wrapper
    return func(*args, **kwargs)
TypeError: a bytes-like object is required, not 'str'

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1692058 - Open temporary file in w mode when running multiple junit tests.

We're trying to store a string in a file open in binary mode which doesn't work :)

I'm guessing this was allowed in Python2 or some older 3 version.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12636a032785
Open temporary file in w mode when running multiple junit tests. r=droeh,mhentges

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/12636a032785