1692066 - Save to Pocket button message response don't need panel ids in their name

Status: RESOLVED FIXED

(Firefox :: Pocket, enhancement, P2)

Description

[Scott [:thecount] Downe]

Right now the messaging system for the save to Pocket button has an id in the response from the time when it was in an iframe to ensure no other events or panels may be listening. By putting the panel id right in the message response name, it made it unique.

The new messaging system is a 1 to 1 relationship, so there is no need to setup a unique event name, and it also means we can now allowlist all our event names because they are now static.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1692066 - Pocket panels remove panel id from messaging.

Comment 2

[Scott [:thecount] Downe]

Steps to test:

1. Open an article of some sort, a rec from newtab for example.
2. Log into Pocket using the Pocket panel.
3. Save the article, make sure it' saved to your Pocket.
4. Click some of the on save recs in the panel.
5. Delete the article, make sure it's now gone.
6. Log out.

That should do it. It's just regression testing, really. If this is going to break something, it's likely to break it in very noticeable ways, and the panel would become non functional completely.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2d46aeb34e1
Pocket panels remove panel id from messaging. r=gvn

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d2d46aeb34e1