Closed Bug 1692103 Opened 4 years ago Closed 4 years ago

Logging problems with --enable-bootstrap

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox-esr78 unaffected, firefox85 unaffected, firefox86 wontfix, firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- wontfix
firefox87 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.

The code in MozbuildObject.get_mozconfig_and_target relies on the
configure sandbox to find mozconfig (and target). With
--enable-bootstrap, configure itself ends up calling into taskgraph code
that, eventually ends in in MozbuildObject.get_mozconfig_and_target,
which, because it currently logs to the same place, has at least the
following two effects:

  • MOZ_CONFIGURE_TRACE logging breaks. I'm not sure exactly why, but the
    log level is lost.
  • the output from the configure code that runs for
    MozbuildObject.get_mozconfig_and_target ends up mixed with the output
    from configure itself, and it appears to the user as if things happened
    twice (which it did, actually, but that's not something that should be
    shown to the user).

So, we redirect to a separate logger.

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/c0c0530991a6 When getting mozconfig info for MozbuildObject, log separately. r=firefox-build-system-reviewers,mhentges
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

Set release status flags based on info from the regressing bug 1553230

Regressions: 1692611
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: