1692192 - Nightly: Addon custom keyboard shortcut is cleared after each restart.

Status: RESOLVED MOVED

(WebExtensions :: Developer Outreach, task, P3)

Description

[Caspy7]

Running Nightly.
I have the Stylus addon installed.
For a very long time I had set the enable/disable all styles toggle to have a keyboard shortcut (shift+alt+period) but a few days ago it disappeared. I checked the Manage Extension Shortcuts area and found that the shortcut was blank suddenly so I re-set it again and things were working.
Ever since then shortcut has been clearing itself again after each restart.

I have another addon (uBlock Origin) for which I've set another shortcut (ctrl+alt+X to enter element zapper mode). It has remained unaffected.

Comment 1

[Caspy7]

I tested in a fresh profile and and was able to reproduce the issue using both the same keyboard shortcut and a different one.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Alex, would you mind to try to reproduce this (and to bisect the regressing change using mozregression if you are able to reproduce)?

Comment 4

[Alex Cornestean]

I reproduced the issue on the latest Nightly (121.0a1/20231106094018) on Windows 10 x64 using the latest version of the extension (Version 1.5.35, released Aug 30, 2023).

Tried running a mozregression using the same latest version of the add-on and builds down to 2018 seemed to manifest this issue.

However, I next tried to check whether it was not Firefox at fault but instead the extension itself that was causing this. So I tested the extension versions from the period of the report:

• Version 1.5.15, released Feb 4, 2021 (this version was released a week before the issue was reported). This version has the shortcut reset issue on the latest Nightly
  AND
• Version 1.5.13, released Jul 24, 2020. This version does not have the shortcut reset issue on the latest Nightly.

In conclusion, the issue lies with the extension itself (Stylus) and not Firefox. This is why the issue did not happen with uBlock Origin, as per the original report.

Hope this helps !

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Shane to forward this to the who will be responsible for reaching out the author.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Working out the workflow for these is in progress, removing ni.

Comment 7

[Abhishek Nagekar [:Abhi]]

Developer was reached out to via AMO