1692350 - Implement a telemetry probe to collect page load data for documents that use lazyload

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Sean Feng [:sefeng]]

In order to ensure tweaking lazyload thresholds won't regress page load performance. We want to introduce a new telemetry probe to collect page load metrics for documents that use lazyload.

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1692350 - Implement a telemetry probe to collect page load data for documents that use lazyload r=emilio

Comment 2

[Sean Feng [:sefeng]]

Attachment: data-review-collection.txt

Comment 3

[Chris H-C :chutten]

Comment on attachment 9202929 [details]
data-review-collection.txt

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :sefeng is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a0dcd8f4e3e
Implement a telemetry probe to collect page load data for documents that use lazyload r=emilio,chutten

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset 6a0dcd8f4e3e (Bug 1692350) for causing crashes in WindowContext.

Backout link: https://hg.mozilla.org/integration/autoland/rev/74cc2b345932b87eeb4358b31e42297451fd2a96

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=6a0dcd8f4e3e35d27edba6a4fef795cf8174ac78&selectedTaskRun=PdzhKNWeRjeK4ZRMut8Dkg.0

Failure logs:

• bc: https://treeherder.mozilla.org/logviewer?job_id=330276062&repo=autoland&lineNumber=28738
• wpt: https://treeherder.mozilla.org/logviewer?job_id=330277752&repo=autoland&lineNumber=5385

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cc86398ced0
Implement a telemetry probe to collect page load data for documents that use lazyload r=emilio,chutten

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1cc86398ced0