Closed Bug 1692376 Opened 10 months ago Closed 9 months ago

Disabled menu items have a hover background color

Categories

(Firefox :: Menus, defect, P3)

Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox87 --- disabled
firefox88 --- verified

People

(Reporter: yoasif, Assigned: Gijs)

References

Details

(Keywords: nightly-community, Whiteboard: [proton-context-menus])

Attachments

(1 file)

Noticed in the new context menus (browser.proton.contextmenus.enabled=true), that disabled menu items have a light gray background. When compared to Windows Explorer, this is not the platform behavior.

Steps to reproduce:

  1. Set browser.proton.contextmenus.enabled = true
  2. Restart Firefox
  3. Navigate to example.com
  4. right click page

What happens:

Note that the forward button and the View Background menu item appear with a lighter (dark mode, brighter in light mode) background color than the rest of the menu item on hover.

Expected result:

No change on hover for disabled menu items.

Blocks: 1682522
Whiteboard: [proton-context-menus]

Note that this is also the case pre-proton, but the style is different for disabled items compared to non-disabled items. But I guess platform as well as cross-platform compat would suggest disabling the hover style entirely.

Severity: -- → S3
Priority: -- → P3
Hardware: Unspecified → Desktop
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

I'm also updating the colours for the spec updates to menu colours.

Summary: Unavailable menu items have a hover background color → Disabled menu items have a hover background color
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c109ba965efd
stop showing hover state for menuitems in the new windows 10 menus, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Reproduced the initial issue using old Nightly from 2021-02-11, verified that using latest Nightly 88.0a1 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3) the disabled items inside context menus are no longer having hover effect.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.