1692376 - Disabled menu items have a hover background color

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Asif Youssuff]

Noticed in the new context menus (browser.proton.contextmenus.enabled=true), that disabled menu items have a light gray background. When compared to Windows Explorer, this is not the platform behavior.

Steps to reproduce:

1. Set browser.proton.contextmenus.enabled = true
2. Restart Firefox
3. Navigate to example.com
4. right click page

What happens:

Note that the forward button and the View Background menu item appear with a lighter (dark mode, brighter in light mode) background color than the rest of the menu item on hover.

Expected result:

No change on hover for disabled menu items.

Comment 1

[:Gijs (he/him)]

Note that this is also the case pre-proton, but the style is different for disabled items compared to non-disabled items. But I guess platform as well as cross-platform compat would suggest disabling the hover style entirely.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1692376 - stop showing hover state for menuitems in the new windows 10 menus, r?jaws

I'm also updating the colours for the spec updates to menu colours.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c109ba965efd
stop showing hover state for menuitems in the new windows 10 menus, r=jaws

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c109ba965efd

Comment 5

[Bogdan Maris, Desktop QA]

Reproduced the initial issue using old Nightly from 2021-02-11, verified that using latest Nightly 88.0a1 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3) the disabled items inside context menus are no longer having hover effect.