1692462 - Expand wasmDis to work on wasm modules

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

wasmDis run on a wasm module object should disassemble all functions in the module, with at least function boundaries marked. This doesn't look hard at all.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1692462 - Disassemble wasm modules and instances. r?yury

Extend the wasmDis testing function so that it can disassemble
entire wasm modules in addition to exported functions from wasm
instances, this makes it much more useful.

Comment 2

[Lars T Hansen [:lth]]

The current patch works and is useful and we could stop here, but there are a few things it would be useful to consider:

• if the function has a name, print the name with the disassembly, not just the function index
• if there is other information for the function, perhaps print that (TBD) (stretch goal to figure this out)
• it would be nice to be able to select a specific function index in the module to disassemble, this ties into a comment i left in the code about more interesting options for configuring disassembly
• it would be nice to be able to select to disassemble not just normal functions, but stubs and other types of code too, see ditto comment
• this is getting complicated enough that a couple of test cases would be useful

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d737bf8f1ca2
Disassemble wasm modules and instances. r=yury

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset d737bf8f1ca2 (Bug 1692462) for bustages in check_vanilla_allocations.py.
https://hg.mozilla.org/integration/autoland/rev/81c9382d6bc753a611c15c31f7a6be4640b6a409

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=d737bf8f1ca2810d43181870a596c5e15744d9a8&selectedTaskRun=XxnAxOoMQVKJ1Qh-9Qmpdw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=331705377&repo=autoland&lineNumber=3098

Comment 5

[Lars T Hansen [:lth]]

The problem is that the use of std::function to capture the type of a lambda causes a (surprising, to me) introduction of a heap allocation. But using a pattern of a template to capture the unutterable type of the function + a move to ensure in-place construction, we avoid this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a2607cc1663
Disassemble wasm modules and instances. r=yury

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8a2607cc1663