1692639 - Change dom/broadcastchannel/tests/test_bfcache.html to use BroadcastChannel

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Comment 1

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1692639 - Fix dom/broadcastchannel/tests/test_bfcache.html to not use opener

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1692639 - Change dom/broadcastchannel/tests/test_bfcache.html to use BroadcastChannel, r=annyG

This changes the test a bit. It doesn't test BroadcastChannel's postMessage anymore, but receiving the message.
I can't see how postMessage could be tested, since given the new setup, no one should have access to it anymore.

This is functionally now very similar to another test I wrote recently, but I think it is fine to keep this too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f77ab0956d89
Change dom/broadcastchannel/tests/test_bfcache.html to use BroadcastChannel, r=annyG

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_bfcache.html

backout: https://hg.mozilla.org/integration/autoland/rev/2c4ad70732411b23ca13a77b046f11a98b254a86

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=f77ab0956d896006f251507746335479d66b204e&selectedTaskRun=TtS03582QAKaxZqv_OdUlA.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=334618535&repo=autoland&lineNumber=1803

[task 2021-03-27T00:36:21.514Z] 00:36:21 INFO - TEST-PASS | dom/broadcastchannel/tests/test_bfcache.html | test page should have been persisted initially
[task 2021-03-27T00:36:21.514Z] 00:36:21 INFO - Posting a message.
[task 2021-03-27T00:36:21.514Z] 00:36:21 INFO - Going back
[task 2021-03-27T00:36:21.514Z] 00:36:21 INFO - Buffered messages finished
[task 2021-03-27T00:36:21.515Z] 00:36:21 WARNING - TEST-UNEXPECTED-FAIL | dom/broadcastchannel/tests/test_bfcache.html | test page should have been persisted in pageshow - got true, expected false
[task 2021-03-27T00:36:21.515Z] 00:36:21 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2021-03-27T00:36:21.515Z] 00:36:21 INFO - page1Shown@dom/broadcastchannel/tests/test_bfcache.html:43:9
[task 2021-03-27T00:36:21.515Z] 00:36:21 INFO - bc1.onmessage@dom/broadcastchannel/tests/test_bfcache.html:30:15
[task 2021-03-27T00:36:21.515Z] 00:36:21 INFO - Closed
[task 2021-03-27T00:36:21.516Z] 00:36:21 INFO - TEST-OK | dom/broadcastchannel/tests/test_bfcache.html | took 1683ms

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Fun, I broke Android o_O

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf06838068c7
Change dom/broadcastchannel/tests/test_bfcache.html to use BroadcastChannel, r=annyG

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bf06838068c7